Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading Netskope CCP files #11661

Closed

Conversation

mitchellgulledge2
Copy link

Required items, please complete

Change(s):

  • Uploading 4 JSON files that encompass the complete Netskope solution for Alerts and Events

Reason for Change(s):

  • This is for the GA of CCP and Netskope

Testing Completed:

  • Extensive functionality testing and scale testing has been performed

@mitchellgulledge2 mitchellgulledge2 requested review from a team as code owners January 13, 2025 14:41
@v-prasadboke v-prasadboke self-assigned this Jan 15, 2025
@v-prasadboke v-prasadboke added the Connector Connector specialty review needed label Jan 15, 2025
@v-atulyadav
Copy link
Contributor

Hi @mitchellgulledge2,
The DataConnectorDefinition.json file resembles an Azure deployment file and needs to be converted into a CCP ARM template file. Please refer to the CCP folder of the solution provided below as a reference. Additionally, please confirm if this is a new or existing solution (https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/Netskope); if it is an existing solution, ensure that these changes are integrated into that folder.
https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/Ermes%20Browser%20Security/Data%20Connectors/ErmesBrowserSecurityEvents_ccp

@mitchellgulledge2
Copy link
Author

@v-prasadboke apologies I have added the format changes to both the Definition and Poller json files

@v-prasadboke
Copy link
Contributor

Hello @mitchellgulledge2, Is this connector part of new solution or of the existing Netskope Solution.

If this an part of existing Solution please move this Connector to the Solution folder.
Else if this a new one, Solution is missing with input file and solution metadata file.

This both files are required to package the Solution. Please add the missing file. you can refer to any of the Solution from repo for more clarification.

Thanks,
Prasad

@v-prasadboke
Copy link
Contributor

Hello @mitchellgulledge2, Please provide an update on above

@mitchellgulledge2
Copy link
Author

We are making a new PR, we are packaging under existing solution we can close this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Connector Connector specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants