Skip to content
This repository has been archived by the owner on Oct 2, 2024. It is now read-only.

Support workload identity federation and service principals #50

Closed
wants to merge 6 commits into from

Conversation

Botje
Copy link

@Botje Botje commented Nov 7, 2023

This PR adds support for using App Config with a federated identity and service principals. (via client secret)
The necessary inputs are styled after Azure/login.

@Botje Botje changed the title Support workload identity federation Support workload identity federation and service principals Nov 10, 2023
@Botje
Copy link
Author

Botje commented Jan 22, 2024

Any chance this can get a review?

@ChristineWanjau
Copy link
Contributor

ChristineWanjau commented Apr 25, 2024

@Botje Please pull the latest changes from main branch

@Botje Botje force-pushed the feature/workload-identity-federation branch from 0305a2c to 36b4329 Compare April 25, 2024 07:45
src/input.ts Outdated Show resolved Hide resolved
src/input.ts Outdated Show resolved Hide resolved
@Botje
Copy link
Author

Botje commented Apr 26, 2024

I made the changes you suggested. Do you think it is worth creating a test for the "no auth-type set" scenario?

@ChristineWanjau
Copy link
Contributor

@Botje I am just curious, are there any github actions that have used @azure/identity sdk to authenticate to azure? I see most of them recommend the use of @Azure/login.

@Botje
Copy link
Author

Botje commented Apr 30, 2024

I cannot find an NPM package named @Azure/login. Are you talking about the GitHub Action named Azure/login?
That action uses the az cli to log in, and many actions defer authentication to that, yes.

If you prefer that can be added as a fourth authentication mechanism.

@ChristineWanjau
Copy link
Contributor

Hello @Botje we are deprecating this Github action. We recommend using Azure CLI action instead. Follow this guideline to https://learn.microsoft.com/en-us/azure/azure-app-configuration/push-kv-github-action on how to set it up. I am going to go ahead and close this pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants