K8s provider conformance test plugin #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidiesen
approved these changes
May 17, 2024
| } | ||
|
|
||
| # Ensure that we tell the Sonobuoy worker we are done regardless of results. | ||
| trap saveResult EXIT |
There was a problem hiding this comment.
Not sure why we have this command between definition of functions
There was a problem hiding this comment.
The trap command ensures that the saveResult() function is called when the script exits.
| python3 /arc/setup_failure_handler.py | ||
| fi | ||
|
|
||
| if [ -z "${ARC_CLUSTER_NAME}" ]; then |
There was a problem hiding this comment.
It may not a arc cluster if cluster type is "managedCluster"
| --extension-type Microsoft.AppConfiguration \ | ||
| --cluster-name "${ARC_CLUSTER_NAME}" \ | ||
| --resource-group "${ARC_CLUSTER_RG}" \ | ||
| --cluster-type managedClusters \ |
There was a problem hiding this comment.
Could we parameterize this property, like how the flux do https://dev.azure.com/ArcValidationProgram/ArcValidationProgram/_git/ConformanceTesting/commit/251064a0db6c69e0f971bb9a3773cd1aaf398b3f?refName=refs/heads/main&path=/aks/pipeline/scripts/sonobuoy-plugin-args/flux-managed.txt
| python3 /arc/setup_failure_handler.py | ||
| fi | ||
|
|
||
| if [ -z "${ARC_CLUSTER_RG}" ]; then |
There was a problem hiding this comment.
Same here, CLUSTER_RG
linglingye001
force-pushed
the
user/linglingye/testPlugin
branch
from
64cb9a9 to
ecb7065
Compare
linglingye001
force-pushed
the
user/linglingye/testPlugin
branch
from
ea060c6 to
649aa98
Compare
RichardChen820
approved these changes
Jun 27, 2024
linglingye001
added a commit
that referenced
this pull request
Sep 11, 2024
* Not running on windows node (#30) * Bump up version to 2.0.0-preview (#42) * Workload identity support namespaced service account (#39) * Workload identity support namespaced service account * feedback * Feedback * Upgrade package (#44) * fix vulnerability * fix go version * update * update * update * update * update * update controller runtime * upgrade azsecrets package * update ci * update patched version * update * revert version * upgrade packages * update ci * revert * deduplicate feature flags (#50) * Treat get settings from one client failure as warning (#48) * Add node affinity and toleration configuration (#46) * K8s provider conformance test plugin (#43) * k8s provider conformance test plugin * rename * remove docker hub dependency * replace curl with wget * add version file * Setup golangci lint action (#51) * setup golangci lint action * fix linting error * update ci * update * add lint in makefile * Add Correlation Context header for extension (#47) * Add Correlation Context header for extension * Add more context * Add Host and RequestType in correlation context * Remove the kv refresh * update extension test plugin conformance file (#52) * added timeout parameter in golintCI (#54) * Revise the error message for selector object verification (#56) * Bump up version to 2.0.0 (#58) * Add data collection section in readme (#57) * Require to opt-in for the global service account (#60) * Require to opt in the global service account * Rename * Fix vulnerability (#68) * fix vulnerability * specify go version in golang lint ci --------- Co-authored-by: Richard chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.