Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failover support #98

Merged
merged 24 commits into from
Nov 18, 2024
Merged

Failover support #98

merged 24 commits into from
Nov 18, 2024

Conversation

linglingye001
Copy link
Contributor

@linglingye001 linglingye001 commented Sep 14, 2024

Replica Auto-Discovery: For App Configuration stores with geo-replication enabled, the provider will now automatically discover any additional replicas and attempt to connect to them when it fails to connect to user-provided endpoints in code. This capability allows applications to leverage geo-replication for enhanced resiliency without code change and redeployment. Replica discovery is enabled by default and can be disabled by setting the new AzureAppConfigurationOptions.replicaDiscoveryEnabled property equal to false.

Usage:

const appConfig = await load("YOUR-CONNECTION-STRING", {replicaDiscoveryEnabled: true})

Note:

Replica discovery can only work in node.js environment.

@zhiyuanliang-ms zhiyuanliang-ms changed the base branch from main to preview September 23, 2024 09:53
@linglingye001 linglingye001 marked this pull request as ready for review September 30, 2024 08:32
@zhiyuanliang-ms
Copy link
Contributor

zhiyuanliang-ms commented Oct 21, 2024

How about seperating this PR into two smaller PR to make it easier to review. For example, the change of adding client manager can be a seperated PR and I can approve it quickly. And with client manager change merged, it won't block the following new feature like snapshot support.

Copy link
Contributor

@zhiyuanliang-ms zhiyuanliang-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List shuffling should be extracted to a function in utils.ts

@linglingye001 linglingye001 merged commit 7db665f into preview Nov 18, 2024
4 checks passed
@linglingye001 linglingye001 deleted the linglingye/failover branch November 18, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants