Load balance support #135
Load balance support #135
Conversation
src/ConfigurationClientWrapper.ts
Outdated
| @@ -12,7 +12,7 @@ export class ConfigurationClientWrapper { | |||
| endpoint: string; | |||
| client: AppConfigurationClient; | |||
| backoffEndTime: number = 0; // Timestamp | |||
| #failedAttempts: number = 0; | |||
| failedAttempts: number = 0; | |||
There was a problem hiding this comment.
If you have to expose failedAttempt to be public for testing, you should make this private and create another public property which only has getter. And the getter will return the private #failedAttempt. This can make sure failedAttempt won't be modified outside of the class. And add comment to explain the purpose.
src/ConfigurationClientWrapper.ts
Outdated
| if (this.failedAttempts > 0) { | ||
| this.failedAttempts = 0; | ||
| } | ||
| this.failedAttempts -= 1; |
There was a problem hiding this comment.
failedAttempts can be negative. This doesn't make sense. If this behavior is only for testing, don't do that.
test/loadBalance.test.ts
Outdated
| } | ||
| }); | ||
| // one request for key values, one request for feature flags | ||
| expect(fakeClientWrapper_1.failedAttempts).eq(-1); |
There was a problem hiding this comment.
Check this pattern. You can follow this pattern to verify how many times something is called. You can do whatever you want when you stub the fakeClientWrapper. You can set a local counter and when the client is called, counter += 1
A load balancing mode has been introduced, enabling your application to distribute requests to App Configuration across all available replicas.
Usage: