Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline var to skip extension check #5802

Merged
merged 15 commits into from
Feb 12, 2025
Merged

Conversation

timmy-wright
Copy link
Contributor

@timmy-wright timmy-wright commented Feb 11, 2025

What type of PR is this?

/kind chore

What this PR does / why we need it:

This PR lets us skip a particular check when building test VHDs. For prod (release) VHDs, we don't want any VM extensions on the VHD. But for test, it's OK. Not idea, and we should get policy dispensation for the test subscription, but we don't want that to block us.

image

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@timmy-wright timmy-wright enabled auto-merge (squash) February 11, 2025 02:35
Copy link
Collaborator

@Devinwong Devinwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@smith1511 smith1511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookgs good other than my comment/question

@timmy-wright timmy-wright merged commit a7dd571 into master Feb 12, 2025
28 checks passed
@timmy-wright timmy-wright deleted the timmy/skipExtensionCheck branch February 12, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants