Replaces the use of client subnet to use armnetwork.SubnetsClient` #4012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehvs
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
mociarain,
kimorris27 and
tsatam
as code owners
bitoku
reviewed
Dec 16, 2024
pkg/util/purge/resourcegroups.go
Outdated
Comment on lines
79
to
93
| if secGroupSubnet.ID == nil || secGroupSubnet.Name == nil { | ||
| continue | ||
| } | ||
|
|
||
| vnetID, _, err := apisubnet.Split(*secGroupSubnet.ID) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| rc.log.Debugf("Removing security group from subnet: %s/%s/%s", *resourceGroup.Name, *secGroup.Name, *subnet.Name) | ||
| r, err := azure.ParseResourceID(vnetID) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| subnet, err := rc.subnet.Get(ctx, *resourceGroup.Name, r.ResourceName, *secGroupSubnet.Name, nil) |
There was a problem hiding this comment.
You can parse subnet ID like this.
ARO-RP/pkg/cluster/ensureendpoints.go
Lines 33 to 37 in 88f29de
pkg/util/purge/resourcegroups.go
Outdated
Comment on lines
105
to
114
| vnetID, _, err := apisubnet.Split(*subnet.ID) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| err = rc.subnet.CreateOrUpdate(ctx, *subnet.ID, subnet) | ||
| r, err := azure.ParseResourceID(vnetID) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| err = rc.subnet.CreateOrUpdateAndWait(ctx, *resourceGroup.Name, r.ResourceName, *subnet.Name, subnet.Subnet, nil) |
There was a problem hiding this comment.
You can parse subnet ID like this.
ARO-RP/pkg/cluster/ensureendpoints.go
Lines 33 to 37 in 88f29de
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
https://issues.redhat.com/browse/ARO-12538
Replaces the use of client subnet to use
armnetwork.SubnetsClient.What this PR does / why we need it:
Avoid deprecation.
Test plan for issue:
Tested a few times using on
dryrunmode with pipeline Purge RedHat Dev-Gratis.https://msazure.visualstudio.com/AzureRedHatOpenShift/_build/results?buildId=110288783&view=logs&j=a4f1910f-c367-5697-edcd-724d81cde23b&t=bc103e47-9b88-5c56-fcad-f3f2f0b2ed91
Is there any documentation that needs to be updated for this PR?
No