Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove montioring controller to allow setting persistence #4000

Closed
wants to merge 1 commit into from

Conversation

fahlmant
Copy link
Collaborator

Which issue this PR addresses:

Fixes https://issues.redhat.com/browse/ARO-13325
What this PR does / why we need it:

Enables configuration of persistence for the monitoring stack
Test plan for issue:

Create cluster
Deploy ARO operator with changes
Try and edit monitoring configmap
Verify config is not removed
Verify ARO operator logs related to removing config are absent.

Is there any documentation that needs to be updated for this PR?

Probably yes
How do you know this will function as expected in production?

Testing

@fahlmant
Copy link
Collaborator Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Contributor

@hlipsig hlipsig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be better to actually add this to a feature flag which defaults to false similar to the allowReconcile one. Then after we've trialed this for a while do the deletion.

@fahlmant fahlmant closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants