Add disable-infra annotation to hive clusterdeployments #3985
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsatam
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
bitoku and
fahlmant
as code owners
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cadenmarchese
previously approved these changes
Dec 3, 2024
Co-authored-by: Caden Marchese <[email protected]>
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kimorris27
reviewed
Dec 3, 2024
| Annotations: map[string]string{ | ||
| // https://github.com/openshift/hive/pull/2501 | ||
| // Disable hibernation controller as it is not used as part of ARO's Hive implementation | ||
| "hive.openshift.io/infra-disabled": "true", |
There was a problem hiding this comment.
Super nit: we could make a const for this in pkg/hive since it's used in two places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-11607
What this PR does / why we need it:
Adds the
hive.openshift.io/infra-disabledannotation to our Hive ClusterDeployments (for both new installs as well as adopted clusters), set totrue. This is required in order to disable the hibernation controller, which does not currently work for ARO MIWI clusters.Note
This PR currently disables the hibernation controller for all cluster installations (CSP and MIWI) - we do not use this functionality in ARO's implementation of Hive today.
See corresponding change in Hive to add this annotation for more details: openshift/hive#2501
Test plan for issue:
Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
E2E tests outlined above