Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FPSP to MIWI deny assignment ExcludePrincipals #3982

Merged

Conversation

kimorris27
Copy link
Contributor

Which issue this PR addresses:

https://issues.redhat.com/browse/ARO-13246

What this PR does / why we need it:

This PR adds the FPSP to the MIWI deny assignment's ExcludePrincipals. See the Jira for more context on why we're doing this.

Test plan for issue:

Augmented unit tests; will soon test in canary

Is there any documentation that needs to be updated for this PR?

N/A

How do you know this will function as expected in production?

MIWI feature testing

@cadenmarchese
Copy link
Collaborator

/azp run e2e

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@cadenmarchese cadenmarchese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since canary testing is time sensitive, I think we can proceed with merging this without e2e as it will be immediately tested in canary and our CI e2e doesn't have coverage for deny assignment changes since it creates a dev cluster.

@cadenmarchese cadenmarchese merged commit 90981dd into master Dec 2, 2024
20 of 21 checks passed
@kimorris27 kimorris27 deleted the kimorris27/ARO-13246-miwi-deny-assignment-fpsp branch December 2, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chainsaw Pull requests or issues owned by Team Chainsaw ready-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants