-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARO-12459] Deduplicate our dependencies on go-jose to a single version #3969
Conversation
…ons that use josev4
… sometimes the format strings are weird
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
|
||
// AssertErrorMessage asserts that err.Error() is equal to wantMsg. | ||
func AssertErrorMessage(t *testing.T, err error, wantMsg string) { | ||
func AssertErrorMessage(t *testing.T, err error, wantMsg string, opts ...assertOptions) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we introduce unit tests for the function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit hard when it's testing.T code. I did verify that it works as I was using it to help debug the issue :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…on (#3969) * move to go-jose v3 instead of the gopkg.in version * while I'm here, fix license locations * bump to josev4 * update go-oidc, containers/ocicrypt, and letsencrypt/boulder to versions that use josev4 * add the option to not check for whitespace in error checking, because sometimes the format strings are weird * don't check for the whitespace in this error * go mod tidy * go mod vendor
Which issue this PR addresses:
Fixes ARO-12459
What this PR does / why we need it:
Move to go-jose v4 instead of the gopkg.in version + go-jose v3.
Test plan for issue:
E2E, unit tests
Is there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?
E2E