add an update step to replace digicert with onecert #3867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yithian
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
tsatam and
bitoku
as code owners
yithian
force-pushed
the
yithian/ARO-10309
branch
from
13f0c62
to
c60a2b4
Compare
lranjbar
reviewed
Sep 27, 2024
yithian
force-pushed
the
yithian/ARO-10309
branch
from
86b52af
to
0c37e6f
Compare
tsatam
reviewed
Oct 1, 2024
|
/azp run |
|
Commenter does not have sufficient privileges for PR 3867 in repo Azure/ARO-RP |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kimorris27
dismissed
their stale review
Dismissing my approval because E2E is failing with valid failures that we need to address
hlipsig
added
ready-for-review
next-release
fahlmant
approved these changes
Oct 29, 2024
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kimorris27
approved these changes
Oct 29, 2024
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This allows upgrades to 4.16 to proceed. These upgrades were being blocked by the SHA-1 signing algorithm used by DigiCert, which is incompatible with 4.16
yithian
force-pushed
the
yithian/ARO-10309
branch
from
b6ba416
to
b5dbda1
Compare
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
cadenmarchese
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-10309
What this PR does / why we need it:
This allows upgrades to 4.16 to proceed. These upgrades were being blocked by the SHA-1 signing algorithm used by DigiCert, which is incompatible with 4.16
Test plan for issue:
I'm not sure how to test this. It will need to be deployed somewhere with access to an affected cluster
Is there any documentation that needs to be updated for this PR?
No, it's mitigation for an incident
How do you know this will function as expected in production?
The new step is limited to affected clusters only