Incorporate CI and ARM feedback from azure-rest-api-specs to v2024-08-12-preview API #3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadenmarchese
force-pushed
the
cadenmarchese/ARO-4382/api-changes-1
branch
from
83f43ef
to
7a69b14
Compare
tsatam
previously approved these changes
Jul 31, 2024
github-actions
bot
added
needs-rebase
|
Please rebase pull request. |
cadenmarchese
force-pushed
the
cadenmarchese/ARO-4382/api-changes-1
branch
from
70164c7
to
74088f9
Compare
cadenmarchese
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
AldoFusterTurpin and
kimorris27
as code owners
tsatam
previously approved these changes
Oct 28, 2024
|
Please rebase pull request. |
github-actions
bot
added
needs-rebase
fix tag package-2023-11 this was wrong in the readme remove UserAssignedIdentities top level fields must not have additionalproperties update the default tag to latest define a new IdentityType with x-ms-enum modelAsString on identityType x-ms-enum should be false rename IdentityType to ResourceIdentityType to match v3/types.json make client add descriptions to all new API fields make client fix unit test that was failing as a result of removing the UserAssignedIdentity type from the API Adjust a doc comment according to feedback make client
Update client generation to account for swagger subfolder make client fix pwip and validatestatic unit tests fix relative path to common-types migrate from common-types/v3 to common-types/v6 it was requested that we use the latest version of common types. This involves some changes to our examples to match the UUID expected. move from Identity to ManagedServiceIdentity type defined in common-types/v6 use modelerfour.lenient-model-deduplication=true avoids python client generation issues convert PlatformWorkloadIdentity to map ARO-4382 fix unit test cases make generate swagger fix unit tests revert naming openShiftCluster.ManagedServiceIdentity to Identity fix prod code and unit tests post-rebase, reference common-types directly for the identity property
* fix examples to contain identity and type * remove PlatformWorkloadIdentityRoleSetUpdate oct 16th changes oct 17th changes fix issues post-rebase
…a dict instead of a list
appease the linter, fix subscriptionID type in util/azureclient appease the linter again correct log statement, use better naming
cadenmarchese
force-pushed
the
cadenmarchese/ARO-4382/api-changes-1
branch
from
c3e5f8f
to
5620051
Compare
* changes operatorName and roleDefinitionName in PWIRS_List.json
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kimorris27
approved these changes
Oct 29, 2024
tsatam
approved these changes
Oct 29, 2024
shubhadapaithankar
pushed a commit
that referenced
this pull request
Oct 31, 2024
…-12-preview API (#3727) * api changes fix tag package-2023-11 this was wrong in the readme remove UserAssignedIdentities top level fields must not have additionalproperties update the default tag to latest define a new IdentityType with x-ms-enum modelAsString on identityType x-ms-enum should be false rename IdentityType to ResourceIdentityType to match v3/types.json make client add descriptions to all new API fields make client fix unit test that was failing as a result of removing the UserAssignedIdentity type from the API Adjust a doc comment according to feedback make client * add platformworkloadidentityroleset to API definition and examples Update client generation to account for swagger subfolder make client fix pwip and validatestatic unit tests fix relative path to common-types migrate from common-types/v3 to common-types/v6 it was requested that we use the latest version of common types. This involves some changes to our examples to match the UUID expected. move from Identity to ManagedServiceIdentity type defined in common-types/v6 use modelerfour.lenient-model-deduplication=true avoids python client generation issues convert PlatformWorkloadIdentity to map ARO-4382 fix unit test cases make generate swagger fix unit tests revert naming openShiftCluster.ManagedServiceIdentity to Identity fix prod code and unit tests post-rebase, reference common-types directly for the identity property * more swagger CI fixes * fix examples to contain identity and type * remove PlatformWorkloadIdentityRoleSetUpdate oct 16th changes oct 17th changes fix issues post-rebase * update readme to contain suppression for avoidAdditionalProperties * fix ModelValidation error by converting example IDs to resourceIDs * Update python/go clients * Update az aro extension to enumerate platform_workload_identities as a dict instead of a list * Fix python linter issues * configure suppression for PatchBodyParametersSchema appease the linter, fix subscriptionID type in util/azureclient appease the linter again correct log statement, use better naming * regenerate examples * changes operatorName and roleDefinitionName in PWIRS_List.json --------- Co-authored-by: Tanmay Satam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
https://issues.redhat.com/browse/ARO-4382
What this PR does / why we need it:
I opened up a PR to azure-rest-api-specs with our new API version: Azure/azure-rest-api-specs#30004
These are the changes that were required to unblock CI / resolve breaking change and other CI failures.
Test plan for issue:
Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?