Clean up some duplicated code in cmd/ #3648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkowl
added
size-small
hawkowl
requested review from
jewzaam,
bennerv,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
tiguelu
as code owners
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bitoku
reviewed
Jun 26, 2024
pkg/util/service/database.go
Outdated
| @@ -0,0 +1,71 @@ | |||
| package service | |||
There was a problem hiding this comment.
Can we make it more specific?
service is too general although it only concerns about cosmosdb.
There was a problem hiding this comment.
I agree with Ayato. Maybe splitting them into util/database and util/encryption would help.
What do you think?
pkg/util/service/helpers.go
Outdated
| "github.com/Azure/ARO-RP/pkg/env" | ||
| ) | ||
|
|
||
| func DBName(isLocalDevelopmentMode bool) (string, error) { |
There was a problem hiding this comment.
It would make more sense to me if env package has this method (or core interface?).
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hawkowl
force-pushed
the
hawkowl/util-service-cleanup
branch
from
e466bc8
to
f64c758
Compare
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
mociarain
reviewed
Jul 4, 2024
pkg/util/service/database.go
Outdated
| @@ -0,0 +1,71 @@ | |||
| package service | |||
There was a problem hiding this comment.
I agree with Ayato. Maybe splitting them into util/database and util/encryption would help.
What do you think?
|
Please rebase pull request. |
hawkowl
force-pushed
the
hawkowl/util-service-cleanup
branch
from
f64c758
to
f408e3a
Compare
hawkowl
requested review from
SrinivasAtmakuri,
AldoFusterTurpin,
kimorris27 and
tsatam
as code owners
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Part of issues.redhat.com/browse/ARO-4895 (breaking out #3571)
What this PR does / why we need it:
Reduces some duplication in cmd/ that will get repeated in MIMO
Test plan for issue:
Unit tests, E2E
Is there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?
E2E