Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MISE Middleware #3555

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

MISE Middleware #3555

wants to merge 2 commits into from

Conversation

SrinivasAtmakuri
Copy link
Contributor

Which issue this PR addresses:

Fixes

What this PR does / why we need it:

Test plan for issue:

Is there any documentation that needs to be updated for this PR?

How do you know this will function as expected in production?

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Please rebase pull request.

@github-actions github-actions bot added the needs-rebase branch needs a rebase label May 3, 2024
@SrinivasAtmakuri SrinivasAtmakuri force-pushed the SrinivasAtmakuri/ARO-7306 branch from d12cef5 to f33eca1 Compare July 18, 2024 08:51
@github-actions github-actions bot removed the needs-rebase branch needs a rebase label Jul 18, 2024
@SrinivasAtmakuri SrinivasAtmakuri self-assigned this Jul 18, 2024
@SrinivasAtmakuri SrinivasAtmakuri force-pushed the SrinivasAtmakuri/ARO-7306 branch from f33eca1 to 51130b5 Compare July 18, 2024 09:02
@github-actions GitHub Actions
Copy link

Please rebase pull request.

@github-actions github-actions bot added the needs-rebase branch needs a rebase label Jul 22, 2024
@SrinivasAtmakuri SrinivasAtmakuri force-pushed the SrinivasAtmakuri/ARO-7306 branch from de8d9c7 to 51130b5 Compare July 23, 2024 07:23
@SrinivasAtmakuri SrinivasAtmakuri force-pushed the SrinivasAtmakuri/ARO-7306 branch 3 times, most recently from e3c0221 to e1ffb92 Compare August 14, 2024 08:10
@github-actions github-actions bot removed the needs-rebase branch needs a rebase label Aug 14, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 14, 2024
View reviewed changes
pkg/util/miseadapter/authorizer.go Fixed Show fixed Hide fixed
pkg/util/miseadapter/miseadapter.go Fixed Show fixed Hide fixed
@SrinivasAtmakuri SrinivasAtmakuri added the firefly Issues or Pull requests owned by Team Firefly label Aug 14, 2024
@SrinivasAtmakuri SrinivasAtmakuri changed the title INT Testing - MISE MISE Middleware Aug 20, 2024
@SrinivasAtmakuri SrinivasAtmakuri marked this pull request as ready for review August 20, 2024 19:04
@SrinivasAtmakuri SrinivasAtmakuri force-pushed the SrinivasAtmakuri/ARO-7306 branch 2 times, most recently from 95a4c52 to 65cb0cb Compare September 11, 2024 08:36
@github-actions github-actions bot added needs-rebase branch needs a rebase and removed ready-for-review labels Sep 12, 2024
@github-actions GitHub Actions
Copy link

Please rebase pull request.

@SrinivasAtmakuri SrinivasAtmakuri added next-up release-blocker next-release To be included in the next RP release rollout labels Sep 24, 2024
@SrinivasAtmakuri SrinivasAtmakuri force-pushed the SrinivasAtmakuri/ARO-7306 branch from 1222e9d to 35ceb49 Compare October 1, 2024 07:55
@github-actions github-actions bot removed the needs-rebase branch needs a rebase label Oct 1, 2024
@SrinivasAtmakuri SrinivasAtmakuri force-pushed the SrinivasAtmakuri/ARO-7306 branch from 35ceb49 to f07130f Compare October 1, 2024 08:01
@github-actions github-actions bot added needs-rebase branch needs a rebase and removed ready-for-review labels Oct 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Please rebase pull request.

@SrinivasAtmakuri SrinivasAtmakuri force-pushed the SrinivasAtmakuri/ARO-7306 branch from f07130f to 88c7bf5 Compare October 7, 2024 09:11
@github-actions github-actions bot removed the needs-rebase branch needs a rebase label Oct 7, 2024
@SrinivasAtmakuri SrinivasAtmakuri force-pushed the SrinivasAtmakuri/ARO-7306 branch from b9091b9 to 0d52bbd Compare October 11, 2024 09:59
bennerv
bennerv reviewed Oct 24, 2024
View reviewed changes
pkg/deploy/config.go Outdated Show resolved Hide resolved
bennerv
bennerv reviewed Oct 24, 2024
View reviewed changes
pkg/deploy/config.go Outdated Show resolved Hide resolved
bennerv
bennerv reviewed Oct 24, 2024
View reviewed changes
pkg/deploy/devconfig.go
@@ -174,6 +175,13 @@ func DevConfig(_env env.Core) (*Config, error) {
MDMFrontendURL: ptr.To("https://global.ppe.microsoftmetrics.com/"),
MDSDEnvironment: ptr.To(version.DevGenevaLoggingEnvironment),
MsiRpEndpoint: ptr.To("https://iamaplaceholder.com"),
MISEVALIDAUDIENCES: []string{
"https://management.core.windows.net/",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this consistent every cloud? Should this be a config?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for generating devconfig for full RP deployment, so there is no ARM involved, which means MISE will not be needed. I have added a test detail to make it pass validation.

bennerv
bennerv reviewed Oct 24, 2024
View reviewed changes
pkg/deploy/devconfig.go
_env.Environment().ResourceManagerEndpoint,
},
MISEVALIDAPPIDs: []string{
"2187cde1-7e28-4645-9104-19edfa500053",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we read this in as config.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for generating devconfig for full RP deployment, so there is no ARM involved, which means MISE will not be needed. I have added a test detail to make it pass validation.

@SrinivasAtmakuri SrinivasAtmakuri force-pushed the SrinivasAtmakuri/ARO-7306 branch from 8841549 to 739df01 Compare November 4, 2024 10:51
sankur-codes
sankur-codes requested changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@sankur-codes sankur-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed change.

pkg/deploy/devconfig.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennerv bennerv bennerv left review comments

@sankur-codes sankur-codes sankur-codes requested changes

@jewzaam jewzaam Awaiting requested review from jewzaam jewzaam is a code owner

@hawkowl hawkowl Awaiting requested review from hawkowl hawkowl is a code owner

@rogbas rogbas Awaiting requested review from rogbas rogbas is a code owner

@petrkotas petrkotas Awaiting requested review from petrkotas petrkotas is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22 jharrington22 is a code owner

@cblecker cblecker Awaiting requested review from cblecker cblecker is a code owner

@cadenmarchese cadenmarchese Awaiting requested review from cadenmarchese cadenmarchese is a code owner

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@yjst2012 yjst2012 Awaiting requested review from yjst2012 yjst2012 is a code owner

@jaitaiwan jaitaiwan Awaiting requested review from jaitaiwan jaitaiwan is a code owner

@anshulvermapatel anshulvermapatel Awaiting requested review from anshulvermapatel anshulvermapatel is a code owner

@hlipsig hlipsig Awaiting requested review from hlipsig hlipsig is a code owner

@tiguelu tiguelu Awaiting requested review from tiguelu tiguelu is a code owner

@mociarain mociarain Awaiting requested review from mociarain mociarain is a code owner

@kimorris27 kimorris27 Awaiting requested review from kimorris27 kimorris27 is a code owner

@tsatam tsatam Awaiting requested review from tsatam tsatam is a code owner

@bitoku bitoku Awaiting requested review from bitoku bitoku is a code owner

@fahlmant fahlmant Awaiting requested review from fahlmant fahlmant is a code owner

@s-fairchild s-fairchild Awaiting requested review from s-fairchild

Requested changes must be addressed to merge this pull request.

Assignees

@SrinivasAtmakuri SrinivasAtmakuri

Labels
firefly Issues or Pull requests owned by Team Firefly next-release To be included in the next RP release rollout next-up release-blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SrinivasAtmakuri @bennerv @sankur-codes @s-fairchild