Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix hubNetworking module output when DDoS is disabled #861

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

cconstantin
Copy link
Contributor

When disabling DDoS in hubNetworking the module fails because the DDoS plan is not actually provisioned and the output always requires it.

Overview/Summary

The DDoS plan id output is not conditional on whether DDoS is enabled, leading to failures.

Related Issues/Work Items

This PR fixes/adds/changes/removes

#860

Breaking Changes

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

When disabling DDoS in hubNetworking the module fails because the DDoS plan is not actually provisioned and the output always requires it.
@cconstantin cconstantin changed the title Fix hubNetworking module output when DDoS is disabled [fix] Fix hubNetworking module output when DDoS is disabled Sep 21, 2024
@cconstantin cconstantin changed the title [fix] Fix hubNetworking module output when DDoS is disabled fix: Fix hubNetworking module output when DDoS is disabled Sep 21, 2024
@oZakari oZakari added Type: Bug 🪲 Something isn't working Area: Networking 🌐 Issues / PR's related to Networking labels Sep 22, 2024
@Azure Azure deleted a comment from azure-pipelines bot Sep 22, 2024
@oZakari
Copy link
Contributor

oZakari commented Sep 22, 2024

/azp run validateazcloud

Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cconstantin, thanks so much for submitting this PR to fix this!

@oZakari oZakari merged commit b5f811d into Azure:main Sep 23, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Networking 🌐 Issues / PR's related to Networking Type: Bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants