Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Policy Assignment - Configure Azure PaaS services to use private DNS zones #897

Closed
2 tasks done
gerrynicol opened this issue Nov 8, 2024 · 3 comments · Fixed by #903
Closed
2 tasks done
Labels
Area: Policy 📝 Issues / PR's related to Policy Status: In PR 👉 This is when an issue is due to be fixed in an open PR Type: Bug 🪲 Something isn't working

Comments

@gerrynicol
Copy link

What happened? Provide a clear and concise description of the bug, including deployment details.

It looks like the Table Storage Private DNS Zone is missing from this policy. Is this still an issue as per the link below?

Azure/Enterprise-Scale#1502

Please provide the correlation id associated with your error or bug.

No error, missing DNS zone for table storage

What was the expected outcome?

Zone added

Relevant log output

Check previous GitHub issues

  • I have searched the issues for this item and found no duplicate

Code of Conduct

  • I agree to follow this project's Code of Conduct
@oZakari oZakari added Area: Policy 📝 Issues / PR's related to Policy Type: Bug 🪲 Something isn't working labels Nov 12, 2024
@oZakari
Copy link
Contributor

oZakari commented Nov 12, 2024

Hi @gerrynicol, this looks to have been corrected in this PR here from the upstream (Enterprise Scale) repo which was just merged.

If you're still having issues, please let us know.

@oZakari oZakari closed this as completed Nov 12, 2024
@gerrynicol
Copy link
Author

@oZakari I don't think this has been updated in the assignments, only the definition files, based on that link you provided, but I could be wrong

infra-as-code/bicep/modules/policy/definitions/lib/policy_set_definitions/policy_set_definition_es_Deploy-Private-DNS-Zones.json
infra-as-code/bicep/modules/policy/definitions/lib/policy_set_definitions/policy_set_definition_es_Deploy-Private-DNS-Zones.parameters.json

@oZakari
Copy link
Contributor

oZakari commented Nov 13, 2024

Ah yes, I see what're you saying. Thanks for clarification and good catch! Looks like we missed that in the PR that fixed the definitions. Reopening this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Policy 📝 Issues / PR's related to Policy Status: In PR 👉 This is when an issue is due to be fixed in an open PR Type: Bug 🪲 Something isn't working
Projects
None yet
2 participants