fix: Add missing private dns zones to applicable policy assignment and module #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oZakari
added
Area: Policy 📝
oZakari
force-pushed
the
fix-dns-policy-assignment
branch
from
9537788 to
cb4a19e
Compare
oZakari
changed the title
oZakari
changed the title
oZakari
force-pushed
the
fix-dns-policy-assignment
branch
from
bcc8d25 to
17e84f7
Compare
|
/azp run validateazcloud |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run validateazcloud |
|
Azure Pipelines successfully started running 1 pipeline(s). |
oZakari
temporarily deployed
to
BicepUpdateDocumentation
GitHub Actions
Inactive
|
/azp run validateazcloud |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jtracey93
approved these changes
Nov 27, 2024
jtracey93
requested changes
Nov 27, 2024
infra-as-code/bicep/modules/policy/assignments/alzDefaults/alzDefaultPolicyAssignments.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/assignments/alzDefaults/alzDefaultPolicyAssignments.bicep
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
the
Needs: Author Feedback 👂
…s-policy-assignment
microsoft-github-policy-service
bot
removed
the
Needs: Author Feedback 👂
oZakari
temporarily deployed
to
BicepUpdateDocumentation
GitHub Actions
Inactive
|
/azp run validateazcloud |
|
Azure Pipelines successfully started running 1 pipeline(s). |
oZakari
temporarily deployed
to
BicepUpdateDocumentation
GitHub Actions
Inactive
oZakari
temporarily deployed
to
BicepUpdateDocumentation
GitHub Actions
Inactive
…ALZ-Bicep into fix-dns-policy-assignment
oZakari
temporarily deployed
to
BicepUpdateDocumentation
GitHub Actions
Inactive
|
/azp run validateazcloud |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run validateazcloud |
|
Azure Pipelines successfully started running 1 pipeline(s). |
oZakari
requested a deployment
to
BicepUpdateDocumentation
GitHub Actions
Waiting
oZakari
added a commit
that referenced
this pull request
Dec 7, 2024
…d module (#903) * Fix private dns zone list in policy assignment * Remove unused dns zone ids and update param names * Remove unused dns zone ids and update param names * Update generated docs * Add param to accelerator * Generate Parameter Markdowns [oZakari/1618d0f4] * Fix value for param * Add prefix to dependabot title * Update test values * Updated param table * Generate Parameter Markdowns [oZakari/640a1dbc] * Update logic * Update spacing * Add params to parameter file * Generate Parameter Markdowns [oZakari/0a582834] --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This pull request includes significant updates to the configuration and policy assignment files, primarily focusing on the management of private DNS zones and the addition of geographical codes.
Configuration updates:
.github/dependabot.yml: Added a commit message prefix configuration for dependabot updates.accelerator/.config/ALZ-Powershell-Auto.config.json: Added a new parameter for the location of private DNS zones.Policy assignment updates:
infra-as-code/bicep/modules/policy/assignments/alzDefaults/alzDefaultPolicyAssignments.bicep: Added a new parameter for the location of private DNS zones and introduced a dictionary of geographical codes. [1] [2]infra-as-code/bicep/modules/policy/assignments/alzDefaults/alzDefaultPolicyAssignments.bicep: Expanded the list of private DNS zones to include additional Azure services.infra-as-code/bicep/modules/policy/assignments/alzDefaults/alzDefaultPolicyAssignments.bicep: Updated the policy assignment module to incorporate the newly added private DNS zones.Related Issues/Work Items
Fixes #897
This PR fixes/adds/changes/removes
Breaking Changes
None
Testing Evidence
Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have
.bicepfile/s I am adding/editing are using the latest API version possiblemainbranch