rename aad to EID and remove OSM #111
Conversation
There was a problem hiding this comment.
I started, can you take the feedback provided here and apply it to the other places.
It's okay that you have "EID" in the file name (but please don't use it in any markdown or code comments (unless referencing the filename). EID is not an approved TLA for Microsoft Entra ID. If you really need it short, for code purposes, eid is fine, but entraId or entra can work in many cases as well. Just make sure those usages are limited to code/filenames and not sentences/comments :)
Scenarios/AKS-OpenAI-CogServe-Redis-Embeddings/ACR-Build-CICD-Challenge.md
Outdated
Show resolved
Hide resolved
Scenarios/AKS-Secure-Baseline-PrivateCluster/Bicep/02a-DeployUsingGitHubActions.md
Outdated
Show resolved
Hide resolved
...os/AKS-Secure-Baseline-PrivateCluster/Terraform/07-AKS-cluster-existing-infra/aks-cluster.tf
Outdated
Show resolved
Hide resolved
...S-Secure-Baseline-PrivateCluster/Terraform/07-AKS-cluster-existing-infra/aks-pod-identity.tf
Outdated
Show resolved
Hide resolved
...S-Secure-Baseline-PrivateCluster/Terraform/07-AKS-cluster-existing-infra/aks-pod-identity.tf
Outdated
Show resolved
Hide resolved
…singGitHubActions.md Co-authored-by: Chad Kittel <[email protected]>
…cluster-existing-infra/aks-cluster.tf Co-authored-by: Chad Kittel <[email protected]>
There was a problem hiding this comment.
Please apply the suggestions below, and in a follow up PR, please address the assets:
- media/aks-eslz-architecture.png
- materials/Overview of Entrprise Scale for AKS.pptx (and any other item in materials/ that references it (I only checked one) -- while you're at it, you could fix the typo in this filename too "Entrprise" -> "Enterprise" :)
Scenarios/AKS-OpenAI-CogServe-Redis-Embeddings/ACR-Build-CICD-Challenge.md
Outdated
Show resolved
Hide resolved
Scenarios/AKS-Secure-Baseline-PrivateCluster/Terraform/03-eid.md
Outdated
Show resolved
Hide resolved
Scenarios/AKS-Secure-Baseline-PrivateCluster/Terraform/03-eid.md
Outdated
Show resolved
Hide resolved
Scenarios/AKS-Secure-Baseline-PrivateCluster/Terraform/03-eid.md
Outdated
Show resolved
Hide resolved
Scenarios/AKS-Secure-Baseline-PrivateCluster/Terraform/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I applied some edits (please check them out): 8620491 (#111)
Also, please see the comment in this review for a few more items to fix, but can be done in a followup PR. #111 (review)
No description provided.