Update Msal #28
Merged
Update Msal #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neha-bhargava
added
do-not-merge
neha-bhargava
requested review from
jmprieur,
bgavrilMS,
jennyf19,
pmaytak and
trwalke
bgavrilMS
reviewed
Nov 25, 2020
bgavrilMS
reviewed
Nov 25, 2020
bgavrilMS
reviewed
Nov 25, 2020
bgavrilMS
reviewed
Nov 25, 2020
This reverts commit e4641a1.
|
Reverted the last update and updated MSAL again with the trick @bgavrilMS suggested. https://github.com/NuGet/docs.microsoft.com-nuget/issues/860#issuecomment-409207305 |
bgavrilMS
reviewed
Nov 30, 2020
| <Content Include="Scripts\jquery-3.4.1.slim.min.map" /> | ||
| <Content Include="Scripts\jquery-3.4.1.min.map" /> | ||
| <None Include="app.config" /> | ||
| </ItemGroup> | ||
| <ItemGroup> |
There was a problem hiding this comment.
Nice. So the trick worked?
There was a problem hiding this comment.
Yes it did. But after applying the trick I had to add back a lot of stuff it removed and change. But a lot less work than manually doing it. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.