Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial changes to allow sample js to work with ESM v1.33.1 #2132

Merged
merged 6 commits into from
Nov 9, 2023
Merged

initial changes to allow sample js to work with ESM v1.33.1 #2132

merged 6 commits into from
Nov 9, 2023

Conversation

glharper
Copy link
Member

@glharper glharper commented Nov 9, 2023

Purpose

  • ...
    allow sample js to work with ESM v1.33.1

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ x] Documentation content changes
[ ] Other... Please describe:

@glharper glharper merged commit cee450a into master Nov 9, 2023
4 checks passed
@glharper glharper deleted the glharper/node-module-change branch November 9, 2023 23:49
@glharper glharper mentioned this pull request Nov 16, 2023
Closed
@DevangPatelUK DevangPatelUK mentioned this pull request Jul 10, 2024
Open
@DevangPatelUK DevangPatelUK mentioned this pull request Jul 23, 2024
Open
This was referenced Sep 5, 2024
Open
Open
This was referenced Sep 12, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianMouncer BrianMouncer BrianMouncer approved these changes

@rhurey rhurey Awaiting requested review from rhurey

@chschrae chschrae Awaiting requested review from chschrae

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glharper @BrianMouncer