-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding new Bing Image Search quickstart sample #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aahill for your contribution!
However, there is already a sample:
https://github.com/Azure-Samples/cognitive-services-python-sdk-samples/blob/master/samples/search/image_search_samples.py
If yours brings new scenario, please add it in this last file.
Thanks!
Hi @Imazuel, thanks for the response! I saw the file, but I need to create a new sample to support upcoming updates in the documentation. I've written a 5-minute quickstart that goes through this sample, scoping it to a single user task to generate interest for more fully-featured docs,tutorials, and samples (like the one you mention). Is that alright? |
@@ -0,0 +1,27 @@ | |||
from azure.cognitiveservices.search.imagesearch import ImageSearchAPI | |||
from azure.cognitiveservices.search.imagesearch.models import ImageType, ImageAspect, ImageInsightModule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need this line at all
""" | ||
client = ImageSearchAPI(CognitiveServicesCredentials(subscription_key)) | ||
|
||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the try/except, which is not required here
from msrest.authentication import CognitiveServicesCredentials | ||
|
||
subscription_key = "Enter your key here" | ||
search_term = "canadian rockies" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this variable (not used)
Purpose
This sample adds a new Bing Image Search code sample to compliment upcoming documentation changes on docs.microsoft.com
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
That the application outputs strings from a Bing Image Search query.
Other Information