Combinig cosmos db samples #708
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-data-cosmos-aks-sample sample sample.
kushagraThapar
suggested changes
Jul 5, 2023
| public class CosmosSampleApplication implements CommandLineRunner { | ||
|
|
||
| private static final Logger LOGGER = LoggerFactory.getLogger(CosmosSampleApplication.class); | ||
| public class CosmosdbSpringApplication implements CommandLineRunner { |
There was a problem hiding this comment.
Suggested change
| public class CosmosdbSpringApplication implements CommandLineRunner { | |
| public class CosmosDBSpringApplication implements CommandLineRunner { |
| Assert.isTrue(optionalUserResult.isPresent(), "Cannot find user."); | ||
|
|
||
| final User result = optionalUserResult.get(); | ||
| Assert.state(result.getFirstName().equals(testUser.getFirstName()), "query result firstName doesn't match!"); | ||
| Assert.state(result.getLastName().equals(testUser.getLastName()), "query result lastName doesn't match!"); | ||
|
|
||
| LOGGER.info("findOne in User collection get result: {}", result.toString()); | ||
| LOGGER.info("spring-cloud-azure-data-cosmos-sample successfully run."); | ||
| LOGGER.info("spring-cloud-azure-data-cosmos-sample-aks successfully run."); |
There was a problem hiding this comment.
Was added accidentally when moving from aks sample. Removed. Thanks!
|
@M-Lipin Please take a look at the case where the check fails, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR solves the issue #577.
Does this introduce a breaking change?
[ ] Yes
[x] No
Pull Request Type
The change is a refactoring: combining two Azure spring boot samples (for AKS and a regular one) into one sample.
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:
How to Test
What to Check
Verify that the following are valid
Readme files for Azure spring boot samples.
Other Information
There were some differences between AKS and non-AKS Azure spring boot samples. Need to verify that the change does not break anything.