Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dropped class and apis in storage queue samples #163

Conversation

yiliuTo
Copy link
Contributor

@yiliuTo yiliuTo commented Jan 20, 2022

Update storage queue samples for breaking changes in beta3.

@@ -40,8 +41,7 @@ public String send(@RequestParam("message") String message) {
@GetMapping("/messages")
public String receive() {
this.storageQueueOperation.setMessagePayloadType(String.class);
this.storageQueueOperation.setCheckpointMode(CheckpointMode.MANUAL);
Message<?> message = this.storageQueueOperation.receiveAsync(STORAGE_QUEUE_NAME).block();
Message<?> message = this.storageQueueOperation.receiveAsync(STORAGE_QUEUE_NAME, Duration.ofMillis(30)).block();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

30 millis?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 30s

@backwind1233 backwind1233 self-assigned this Jan 20, 2022
@backwind1233 backwind1233 added the azure-spring All azure-spring related issues label Jan 20, 2022
Copy link
Contributor

@backwind1233 backwind1233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiliuTo yiliuTo merged commit c9d463f into Azure-Samples:spring-cloud-azure_4.0.0-beta.3 Jan 20, 2022
@yiliuTo yiliuTo deleted the update-storage-queue-beta3 branch January 20, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants