servicebus jms queue sample update #158

jialigit · 2022-01-19T02:57:52Z

Attention： remember to cherry pick to spring-cloud-azure_4.0.0-beta.4 branch

Purpose

*Update the ServiceBus Jms Queue sample

Update configuration yml file.
Update README file.
Refactor code, including Filename, variable names...

Does this introduce a breaking change?

[ ] Yes
[x ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check

Verify that the following are valid

...

Other Information

backwind1233 · 2022-01-19T03:49:58Z

@yiliuTo please help review this PR.

yiliuTo · 2022-01-20T06:48:50Z

...-jms/servicebus-jms-queue/src/main/java/com/azure/spring/sample/jms/queue/QueueReceiver.java

-    @JmsListener(destination = QUEUE_NAME, containerFactory = "jmsListenerContainerFactory")
+    /**
+     * Message consumer
+     * @param user user


We should give more detailed explanation for what the parameter of User is used as.

yiliuTo · 2022-01-20T06:49:16Z

...ervicebus-jms-queue/src/main/java/com/azure/spring/sample/jms/queue/QueueSendController.java

 import org.springframework.jms.core.JmsTemplate;
 import org.springframework.web.bind.annotation.PostMapping;
 import org.springframework.web.bind.annotation.RequestParam;
 import org.springframework.web.bind.annotation.RestController;

+/**
+ * Message Producer Mannually.
+ */
 @RestController
 public class QueueSendController {


Let's unify the class naming and remove Controller suffix.

The Controller can be remained I think, it has a post request.

yiliuTo · 2022-01-20T06:52:28Z

...ervicebus-jms-queue/src/main/java/com/azure/spring/sample/jms/queue/QueueSendController.java

    @Autowired
    private JmsTemplate jmsTemplate;

+    /**
+     * @param message username


Why not add the introduction of the method, also we could give full explanation of what the paremeter of message is used as

yiliuTo · 2022-01-20T06:53:32Z

.../servicebus-jms-queue/src/main/java/com/azure/spring/sample/jms/queue/SyncQueueReceiver.java

+import javax.jms.Session;
+
+/**
+ * For reqeust-response pattern of Jms.


yiliuTo · 2022-01-20T06:55:51Z

.../servicebus-jms-queue/src/main/java/com/azure/spring/sample/jms/queue/SyncQueueReceiver.java

+    private JmsTemplate jmsTemplate;
+
+    @Autowired
+    private JmsMessagingTemplate jmsMessagingTemplate;


what is this used for?

yiliuTo · 2022-01-20T06:57:00Z

.../servicebus-jms-queue/src/main/java/com/azure/spring/sample/jms/queue/SyncQueueReceiver.java

+ * Premium Tier Only
+ */
+@Component
+@Profile("sync")


why do we call this profile as sync? Given the description of class javadoc, this profile of sample is trying to introduce the use case of "send and receive" of JmsMessagingTemplate, but do we have special support of it in our library?

yiliuTo · 2022-01-20T06:57:15Z

...cebus-jms-queue/src/main/java/com/azure/spring/sample/jms/queue/SyncQueueSendController.java

+ */
+@RestController
+@Profile("sync")
+public class SyncQueueSendController {


yiliuTo · 2022-01-20T07:08:22Z

...cebus-jms-queue/src/main/java/com/azure/spring/sample/jms/queue/SyncQueueSendController.java

+                                              .createSession(false, Session.AUTO_ACKNOWLEDGE);
+        ObjectMessage objectMessage = session.createObjectMessage(new User(message));
+        objectMessage.setJMSCorrelationID(UUID.randomUUID().toString());
+        objectMessage.setJMSReplyTo(connectionFactory.createContext().createTemporaryQueue());


what is the temporary queue here mean? will it create a queue in Service Bus? And we can comment here to introduce the meaning of message properties we configured.

yiliuTo · 2022-01-20T07:08:53Z

...cebus-jms-queue/src/main/java/com/azure/spring/sample/jms/queue/SyncQueueSendController.java

+        objectMessage.setJMSDeliveryMode(DeliveryMode.NON_PERSISTENT);
+
+        return jmsMessagingTemplate.convertSendAndReceive(new JmsQueue(queueName),
+            objectMessage, User.class); //this operation seems to be blocking + sync


we shouldn't have "seems to be" here

yiliuTo · 2022-01-20T07:14:48Z

...-cloud-azure-starter-servicebus-jms/servicebus-jms-queue/src/main/resources/application.yaml

      pricing-tier: ${PRICING_TIER}
+      pool:
+        enabled: true # To be true to enable the JmsPoolConnectionFactory bean. Default false.
+queuename: que001


Let's follow unified property naming schema and use kebab here

yiliuTo · 2022-01-20T07:16:36Z

We can update this sample and introduce the usage of caching and pooled connection factory, and update the sample of topic as well

backwind1233 · 2022-01-20T07:19:46Z

servicebus/spring-cloud-azure-starter-servicebus-jms/servicebus-jms-queue/README.md

-In your terminal, run `mvn clean spring-boot:run`.
-
-
+Navigate to the project root directory, then run the maven command:


we can update the template and then update all the descriptions here.
issue link

please revert it here.

backwind1233 · 2022-01-20T07:20:09Z

servicebus/spring-cloud-azure-starter-servicebus-jms/servicebus-jms-queue/README.md

 ```shell
 mvn clean spring-boot:run
 ```

 ## Verify This Sample

+1. Verify in your app's logs that a similar message was posted:


                   ```
                   curl -d "" http://localhost:8080/queue?message=hello
                   ```
-. Verify in your app's logs that a similar message was posted:
+. [Optional] Verify in your app's logs that a similar message was posted:

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

servicebus jms queue sample update #158

servicebus jms queue sample update #158

jialigit commented Jan 19, 2022 •

edited by backwind1233

Loading

backwind1233 commented Jan 19, 2022

yiliuTo Jan 20, 2022

yiliuTo Jan 20, 2022

backwind1233 Jan 20, 2022

yiliuTo Jan 20, 2022

yiliuTo Jan 20, 2022

yiliuTo Jan 20, 2022

yiliuTo Jan 20, 2022

yiliuTo Jan 20, 2022

yiliuTo Jan 20, 2022

yiliuTo Jan 20, 2022

yiliuTo Jan 20, 2022

yiliuTo commented Jan 20, 2022 •

edited

Loading

backwind1233 Jan 20, 2022

backwind1233 Jan 20, 2022

backwind1233 Jan 20, 2022

jialigit commented Mar 21, 2022

		In your terminal, run `mvn clean spring-boot:run`.


		Navigate to the project root directory, then run the maven command:

servicebus jms queue sample update #158

servicebus jms queue sample update #158

Conversation

jialigit commented Jan 19, 2022 • edited by backwind1233 Loading

Purpose

Does this introduce a breaking change?

Pull Request Type

How to Test

What to Check

Other Information

backwind1233 commented Jan 19, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yiliuTo commented Jan 20, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jialigit commented Mar 21, 2022

jialigit commented Jan 19, 2022 •

edited by backwind1233

Loading

yiliuTo commented Jan 20, 2022 •

edited

Loading