Updated Python sample for IoT Central 1.0.0b1 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the Python SDK sample to work with last IoT Central management SDK. Included the same functionality as the previous sample, and added examples of new functionality including - enabling system-assigned identity - regional instead of geographic scope - S1 SKU unavailable
poanchen
reviewed
Nov 10, 2021
| poller = iotc.apps.begin_create_or_update(resourceGroup, appName, app) | ||
| result = poller.result() | ||
| print("It worked but it shouldn't have!") | ||
|
|
There was a problem hiding this comment.
add raise Exception here?
There was a problem hiding this comment.
This is inside a try who's except is the success condition and prints "OK", so raising here would print "OK".
poanchen
approved these changes
Nov 10, 2021
| poller = iotc.apps.begin_create_or_update(resourceGroup, appNameS1, app) | ||
| result = poller.result() | ||
| print("It worked but it shouldn't have!") | ||
|
|
There was a problem hiding this comment.
same here add raise Exception
There was a problem hiding this comment.
Exception here means success (we expect exception) so raising exception here would print "OK".
|
Please also update the requirements.txt with latest deps. And the readme if needed. |
Will do. This is pending a version number update on the mgmt package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Python SDK sample to work with latest IoT Central management SDK. Included the same functionality as the previous sample, and added examples of new functionality including