Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the documentation of Azure OpenAI #18

Conversation

pmalarme
Copy link
Collaborator

Purpose

  • Improve the documentation of Azure OpenAI and the usage of the java client library

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Review the changes in root README.md

What to Check

Verify that the following are valid

  • OpenAI is better explained
  • Link to OpenAI client for Java
  • Link to prompt engineering documentation
  • Explanation of where to find the different pieces in the code

Other Information

@pmalarme pmalarme requested a review from aarthiem July 31, 2023 17:16
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 31, 2023
Copy link
Collaborator

@aarthiem aarthiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pierre. have few comments, please review

README.md Outdated

Here's a high level architecture diagram that illustrates these components. Excepted Azure OpenAI, all the other resources are provisioned in a single [resource group](https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/manage-resource-groups-portal) that is created when you create your resources using `azd up`.

![Architecture diagram](./assets/architecture-diagram.png)

> This template provisions resources to an Azure subscription that you will select upon provisioning them. Please refer to the [Pricing calculator for Microsoft Azure](https://azure.microsoft.com/pricing/calculator/) and, if needed, update the included Azure resource definitions found in `infra/main.bicep` to suit your needs.

## Azure OpenAI

This sample application uses Azure OpenAI. It is not part of the automated deployment process. You will need to create an Azure OpenAI resource and configure the application to use it. Please follow the instructions in the [Azure OpenAI documentation](https://learn.microsoft.com/en-us/azure/ai-services/openai/overview#how-do-i-get-access-to-azure-openai) to get access to Azure OpenAI. This sample app was developed and tested using `gpt-4` model. You need the following information from the Azure OpenAI resource to configure the application:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a note for networking options or go with default ones?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


- `azureOpenAiApiKey` - Azure OpenAI API key
- `azureOpenAiEndpoint` - Azure OpenAI endpoint
- `azureOpenAiDeploymentId` - Azure OpenAI deployment ID of `gpt-4` model
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add details for how to retrieve the open ai deployment id

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, lets add links for responsible AI documentation

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done both

…-java-openai-springapps into feature/15-update-the-documentation-to-explain-how-azure-sdk-for-java-is-used-for-openai
…ractices for Azure OpenAI models. Add how to get the key, the endpoint and the deployment id.
Copy link
Collaborator

@aarthiem aarthiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pierre!

@aarthiem aarthiem merged commit e0589bf into main Aug 1, 2023
@aarthiem aarthiem deleted the feature/15-update-the-documentation-to-explain-how-azure-sdk-for-java-is-used-for-openai branch August 1, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the documentation to explain how Azure SDK for Java is used for OpenAI
2 participants