Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support specifying column index in public input declaration #69

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Support specifying column index in public input declaration #69

merged 1 commit into from
Jun 12, 2024

Conversation

fcarreiro
Copy link 

pol public(/*idx=*/0) kernel_inputs;
pol public(/*idx=*/1) kernel_value_out;
pol public(/*idx=*/2) kernel_side_effect_out;
pol public(/*idx=*/3) kernel_metadata_out;

and the verifier is now correctly generated.

@fcarreiro fcarreiro changed the title Support specifying column index in public input declaration. Support specifying column index in public input declaration Jun 11, 2024
@fcarreiro fcarreiro mentioned this pull request Jun 11, 2024
Merged
@fcarreiro fcarreiro requested a review from IlyasRidhuan June 11, 2024 19:37
@dbanks12
Copy link

Nice work! I'll let Ilyas give actual approval, but it looks like this makes things a lot cleared. I always found the __is_public thing weird.

fcarreiro added a commit to AztecProtocol/aztec-packages that referenced this pull request Jun 11, 2024
@fcarreiro
fix(avm): correctly generate public inputs in verifier (#7018)
4c4c17f 
PIL must be compiled with:
AztecProtocol/powdr#69

Now the `__is_public` suffix is also not needed.
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this pull request Jun 12, 2024
@fcarreiro @AztecBot
fix(avm): correctly generate public inputs in verifier (#7018)
6cd5fe7 
PIL must be compiled with:
AztecProtocol/powdr#69

Now the `__is_public` suffix is also not needed.
@IlyasRidhuan IlyasRidhuan merged commit 5ddbe75 into avm Jun 12, 2024
1 of 2 checks passed
@IlyasRidhuan IlyasRidhuan deleted the fc/public-inputs-with-index branch June 12, 2024 07:40
@fcarreiro fcarreiro mentioned this pull request Jun 14, 2024
Closed
Maddiaa0
Maddiaa0 reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@Maddiaa0 Maddiaa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, great work cleaning this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maddiaa0 Maddiaa0 Maddiaa0 left review comments

@IlyasRidhuan IlyasRidhuan IlyasRidhuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fcarreiro @dbanks12 @IlyasRidhuan @Maddiaa0