Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: run acir-format-tests in CI #570

Merged
merged 2 commits into from
Jul 4, 2023
Merged

chore: run acir-format-tests in CI #570

merged 2 commits into from
Jul 4, 2023

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Jul 3, 2023 •
edited
Loading

Description

This PR pulls across the changes in the master circleci config to run the acir-format tests to the "Noir master" branch.

This shows how #528 broke the acir-format tests which need to be updated (along with those in acvm-backend-barretenberg).

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

This was referenced Jul 3, 2023
Open
Merged
@TomAFrench
Copy link
Member Author

TomAFrench commented Jul 3, 2023 •
edited
Loading

@guipublic Can you fix the tests which were broken in #528 here please.

@TomAFrench TomAFrench merged commit 8f6620b into acvm-backend-barretenberg Jul 4, 2023
@TomAFrench TomAFrench deleted the run-acir-tests branch July 4, 2023 11:30
Maddiaa0 pushed a commit that referenced this pull request Jul 5, 2023
@TomAFrench @vezenovm @Maddiaa0
chore: run acir-format-tests in CI (#570)
3da363c 
Co-authored-by: Maxim Vezenov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @vezenovm