chore: Remove usage of ComposerHelper and use CircuitBuilder from the API
#555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codygunton
force-pushed
the
cg/post-split-cleanup
branch
from
83a96e0 to
b6f29d6
Compare
kevaundray
changed the title
ComposerHelper and use CircuitBuilder in the API
codygunton
changed the title
ComposerHelper and use CircuitBuilder in the APIComposerHelper and use CircuitBuilder from the API
codygunton
commented
Jun 28, 2023
| @@ -156,5 +156,6 @@ | |||
| "-g" | |||
| ], | |||
| "cmake.useCMakePresets": "auto", | |||
| "editor.inlayHints.enabled": "offUnlessPressed" | |||
There was a problem hiding this comment.
This is an annoying default probably most people don't want.
| @@ -202,7 +201,7 @@ std::shared_ptr<typename Flavor::ProvingKey> UltraHonkComposerHelper_<Flavor>::c | |||
| // Initialize proving_key | |||
| // TODO(#392)(Kesha): replace composer types. | |||
| proving_key = initialize_proving_key<Flavor>( | |||
| circuit_constructor, crs_factory_.get(), minimum_circuit_size, num_randomized_gates, ComposerType::PLOOKUP); | |||
There was a problem hiding this comment.
I removed the need to pass this argument in so many places. It's only currently needed for Plonk.
| @@ -64,7 +62,7 @@ std::shared_ptr<plonk::proving_key> StandardPlonkComposerHelper::compute_proving | |||
| // Initialize circuit_proving_key | |||
| // TODO(#392)(Kesha): replace composer types. | |||
| circuit_proving_key = proof_system::initialize_proving_key<Flavor>( | |||
There was a problem hiding this comment.
Probably should just extract this CircuitType from flavor, or just move responsibility of encoding this information in vk to a responsibility outside of Bb.
| @@ -56,19 +56,16 @@ class StandardCircuitConstructor : public CircuitConstructorBase<arithmetization | |||
| // m l r o c | |||
| create_poly_gate({ one_idx, one_idx, one_idx, 1, 1, 1, 1, -4 }); | |||
| }; | |||
| // This constructor is needed to simplify switching between circuit constructor and composer | |||
There was a problem hiding this comment.
Here Kesha is referring to the splitting work. This constructor shouldn't exist, and now it doesn't.
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
… the API (AztecProtocol/barretenberg#555) Co-authored-by: Suyash Bagad <[email protected]>
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
… the API (AztecProtocol/barretenberg#555) Co-authored-by: Suyash Bagad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#501 Got rid of the shell composer classes that forwarded function calls to circuit constructors and composer helpers. This PR focuses on renaming objects and moving files to clean up after that work.
Checklist:
@briefdescribing the intended functionality.includedirectives have been added.