Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

everything in namespace bb #794

Closed
ludamad opened this issue Nov 29, 2023 · 0 comments · Fixed by AztecProtocol/aztec-packages#4147
Closed

everything in namespace bb #794

ludamad opened this issue Nov 29, 2023 · 0 comments · Fixed by AztecProtocol/aztec-packages#4147
Assignees
@ludamad

Comments

@ludamad
Copy link
Collaborator

ludamad commented Nov 29, 2023

This contradicts #475
I don't think the namespaces help all that much considering we're always fighting them with using statements anyway. Good namespaces should be comfortable to actually spell out, IMO. We should keep a few like the curve namespaces and collapse everything down to an easy to type bb, which lets us be used as a library / future proof for components but otherwise we don't have to think about namespaces much
@ludamad ludamad mentioned this issue Nov 29, 2023
Merged
@codygunton codygunton mentioned this issue Jan 1, 2024
Closed
@ludamad ludamad mentioned this issue Jan 23, 2024
Merged
codygunton pushed a commit to AztecProtocol/aztec-packages that referenced this issue Jan 23, 2024
@ludamad @ludamad0
refactor(bb): rearrange namespaces (#4147)
5de0a8e 
Resolves AztecProtocol/barretenberg#794

---------

Co-authored-by: ludamad <[email protected]>
AztecBot pushed a commit that referenced this issue Jan 24, 2024
@ludamad @ludamad0 @AztecBot
refactor(bb): rearrange namespaces (#4147)
508a48c 
Resolves #794

---------

Co-authored-by: ludamad <[email protected]>
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@ludamad @ludamad0
refactor(bb): rearrange namespaces (AztecProtocol#4147)
33e0571 
Resolves AztecProtocol/barretenberg#794

---------

Co-authored-by: ludamad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ludamad ludamad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(bb): rearrange namespaces AztecProtocol/aztec-packages
1 participant
@ludamad