-
Notifications
You must be signed in to change notification settings - Fork 106
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: oink recursive verifier (#8121)
Introduce an Oink recursive verifier and use it to replace the equivalent logic in Ultra and PG recursive verifiers. Closes #949
- Loading branch information
1 parent
d359d88
commit ac1e174
Showing
10 changed files
with
212 additions
and
248 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
117 changes: 117 additions & 0 deletions
117
cpp/src/barretenberg/stdlib/honk_verifier/oink_recursive_verifier.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| #include "barretenberg/stdlib/honk_verifier/oink_recursive_verifier.hpp" | ||
|
|
||
| #include "barretenberg/numeric/bitop/get_msb.hpp" | ||
| #include "barretenberg/plonk_honk_shared/library/grand_product_delta.hpp" | ||
| #include "barretenberg/transcript/transcript.hpp" | ||
| #include <utility> | ||
|
|
||
| namespace bb::stdlib::recursion::honk { | ||
|
|
||
| template <typename Flavor> | ||
| OinkRecursiveVerifier_<Flavor>::OinkRecursiveVerifier_(Builder* builder, | ||
| const std::shared_ptr<VerificationKey>& vkey, | ||
| std::shared_ptr<Transcript> transcript, | ||
| std::string domain_separator) | ||
| : key(vkey) | ||
| , builder(builder) | ||
| , transcript(transcript) | ||
| , domain_separator(std::move(domain_separator)) | ||
| {} | ||
|
|
||
| /** | ||
| * @brief This function constructs a recursive verifier circuit for a native Ultra Honk proof of a given flavor. | ||
| * @return Output aggregation object | ||
| */ | ||
| template <typename Flavor> OinkRecursiveVerifier_<Flavor>::Output OinkRecursiveVerifier_<Flavor>::verify() | ||
| { | ||
| using CommitmentLabels = typename Flavor::CommitmentLabels; | ||
| using RelationParams = ::bb::RelationParameters<FF>; | ||
|
|
||
| RelationParams relation_parameters; | ||
| WitnessCommitments commitments; | ||
| CommitmentLabels labels; | ||
|
|
||
| FF circuit_size = transcript->template receive_from_prover<FF>(domain_separator + "circuit_size"); | ||
| transcript->template receive_from_prover<FF>(domain_separator + "public_input_size"); | ||
| transcript->template receive_from_prover<FF>(domain_separator + "pub_inputs_offset"); | ||
|
|
||
| // TODO(https://github.com/AztecProtocol/barretenberg/issues/1032): Uncomment these once it doesn't cause issues | ||
| // with the flows | ||
| // ASSERT(static_cast<uint32_t>(circuit_size.get_value()) == key->circuit_size); | ||
| // ASSERT(static_cast<uint32_t>(public_input_size.get_value()) == key->num_public_inputs); | ||
| // ASSERT(static_cast<uint32_t>(pub_inputs_offset.get_value()) == key->pub_inputs_offset); | ||
|
|
||
| std::vector<FF> public_inputs; | ||
| for (size_t i = 0; i < key->num_public_inputs; ++i) { | ||
| public_inputs.emplace_back( | ||
| transcript->template receive_from_prover<FF>(domain_separator + "public_input_" + std::to_string(i))); | ||
| } | ||
|
|
||
| // Get commitments to first three wire polynomials | ||
| commitments.w_l = transcript->template receive_from_prover<Commitment>(domain_separator + labels.w_l); | ||
| commitments.w_r = transcript->template receive_from_prover<Commitment>(domain_separator + labels.w_r); | ||
| commitments.w_o = transcript->template receive_from_prover<Commitment>(domain_separator + labels.w_o); | ||
|
|
||
| // If Goblin, get commitments to ECC op wire polynomials and DataBus columns | ||
| if constexpr (IsGoblinFlavor<Flavor>) { | ||
| // Receive ECC op wire commitments | ||
| for (auto [commitment, label] : zip_view(commitments.get_ecc_op_wires(), labels.get_ecc_op_wires())) { | ||
| commitment = transcript->template receive_from_prover<Commitment>(domain_separator + label); | ||
| } | ||
|
|
||
| // Receive DataBus related polynomial commitments | ||
| for (auto [commitment, label] : zip_view(commitments.get_databus_entities(), labels.get_databus_entities())) { | ||
| commitment = transcript->template receive_from_prover<Commitment>(domain_separator + label); | ||
| } | ||
| } | ||
|
|
||
| // Get eta challenges; used in RAM/ROM memory records and log derivative lookup argument | ||
| auto [eta, eta_two, eta_three] = transcript->template get_challenges<FF>( | ||
| domain_separator + "eta", domain_separator + "eta_two", domain_separator + "eta_three"); | ||
|
|
||
| // Get commitments to lookup argument polynomials and fourth wire | ||
| commitments.lookup_read_counts = | ||
| transcript->template receive_from_prover<Commitment>(domain_separator + labels.lookup_read_counts); | ||
| commitments.lookup_read_tags = | ||
| transcript->template receive_from_prover<Commitment>(domain_separator + labels.lookup_read_tags); | ||
| commitments.w_4 = transcript->template receive_from_prover<Commitment>(domain_separator + labels.w_4); | ||
|
|
||
| // Get permutation challenges | ||
| auto [beta, gamma] = transcript->template get_challenges<FF>(domain_separator + "beta", domain_separator + "gamma"); | ||
|
|
||
| commitments.lookup_inverses = | ||
| transcript->template receive_from_prover<Commitment>(domain_separator + labels.lookup_inverses); | ||
|
|
||
| // If Goblin (i.e. using DataBus) receive commitments to log-deriv inverses polynomials | ||
| if constexpr (IsGoblinFlavor<Flavor>) { | ||
| for (auto [commitment, label] : zip_view(commitments.get_databus_inverses(), labels.get_databus_inverses())) { | ||
| commitment = transcript->template receive_from_prover<Commitment>(domain_separator + label); | ||
| } | ||
| } | ||
|
|
||
| const FF public_input_delta = compute_public_input_delta<Flavor>( | ||
| public_inputs, beta, gamma, circuit_size, static_cast<uint32_t>(key->pub_inputs_offset)); | ||
|
|
||
| relation_parameters = RelationParameters<FF>{ eta, eta_two, eta_three, beta, gamma, public_input_delta }; | ||
|
|
||
| // Get commitment to permutation and lookup grand products | ||
| commitments.z_perm = transcript->template receive_from_prover<Commitment>(domain_separator + labels.z_perm); | ||
|
|
||
| RelationSeparator alphas; | ||
| for (size_t idx = 0; idx < alphas.size(); idx++) { | ||
| alphas[idx] = transcript->template get_challenge<FF>(domain_separator + "alpha_" + std::to_string(idx)); | ||
| } | ||
|
|
||
| return { .relation_parameters = relation_parameters, | ||
| .commitments = std::move(commitments), | ||
| .public_inputs = public_inputs, | ||
| .alphas = alphas }; | ||
| } | ||
|
|
||
| template class OinkRecursiveVerifier_<bb::UltraRecursiveFlavor_<UltraCircuitBuilder>>; | ||
| template class OinkRecursiveVerifier_<bb::UltraRecursiveFlavor_<MegaCircuitBuilder>>; | ||
| template class OinkRecursiveVerifier_<bb::MegaRecursiveFlavor_<UltraCircuitBuilder>>; | ||
| template class OinkRecursiveVerifier_<bb::MegaRecursiveFlavor_<MegaCircuitBuilder>>; | ||
| template class OinkRecursiveVerifier_<bb::UltraRecursiveFlavor_<CircuitSimulatorBN254>>; | ||
| template class OinkRecursiveVerifier_<bb::MegaRecursiveFlavor_<CircuitSimulatorBN254>>; | ||
| } // namespace bb::stdlib::recursion::honk |
39 changes: 39 additions & 0 deletions
39
cpp/src/barretenberg/stdlib/honk_verifier/oink_recursive_verifier.hpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| #pragma once | ||
| #include "barretenberg/stdlib/transcript/transcript.hpp" | ||
| #include "barretenberg/stdlib_circuit_builders/mega_recursive_flavor.hpp" | ||
| #include "barretenberg/stdlib_circuit_builders/ultra_recursive_flavor.hpp" | ||
|
|
||
| namespace bb::stdlib::recursion::honk { | ||
|
|
||
| template <typename Flavor> class OinkRecursiveVerifier_ { | ||
| public: | ||
| using FF = typename Flavor::FF; | ||
| using Commitment = typename Flavor::Commitment; | ||
| using GroupElement = typename Flavor::GroupElement; | ||
| using VerificationKey = typename Flavor::VerificationKey; | ||
| using Builder = typename Flavor::CircuitBuilder; | ||
| using RelationSeparator = typename Flavor::RelationSeparator; | ||
| using Transcript = bb::BaseTranscript<bb::stdlib::recursion::honk::StdlibTranscriptParams<Builder>>; | ||
| using WitnessCommitments = typename Flavor::WitnessCommitments; | ||
|
|
||
| struct Output { | ||
| bb::RelationParameters<typename Flavor::FF> relation_parameters; | ||
| WitnessCommitments commitments; | ||
| std::vector<typename Flavor::FF> public_inputs; | ||
| typename Flavor::RelationSeparator alphas; | ||
| }; | ||
|
|
||
| explicit OinkRecursiveVerifier_(Builder* builder, | ||
| const std::shared_ptr<VerificationKey>& vkey, | ||
| std::shared_ptr<Transcript> transcript, | ||
| std::string domain_separator = ""); | ||
|
|
||
| Output verify(); | ||
|
|
||
| std::shared_ptr<VerificationKey> key; | ||
| Builder* builder; | ||
| std::shared_ptr<Transcript> transcript; | ||
| std::string domain_separator; // used in PG to distinguish between instances in transcript | ||
| }; | ||
|
|
||
| } // namespace bb::stdlib::recursion::honk |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.