Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pull out array_set pass changes #9993

Merged
merged 5 commits into from
Nov 18, 2024
Merged

chore: pull out array_set pass changes #9993

merged 5 commits into from
Nov 18, 2024

Conversation

TomAFrench
Copy link
Member

Please read contributing guidelines and remove this line.

@github-actions GitHub Actions
Copy link
Contributor

Changes to public function bytecode sizes

Generated at commit: 700515b14f8410534ebfb60264635e2b3764b0a1, compared to commit: 44ea5fbccc944a609cce7fd2a488c63ec2ed5169

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
Test::create_l2_to_l1_message_public +160 ❌ +7.84%
AvmTest::pedersen_hash +160 ❌ +5.45%
AvmTest::pedersen_hash_with_index +160 ❌ +5.45%
CardGame::start_game +200 ❌ +2.87%
CardGame::public_dispatch +400 ❌ +2.46%
Test::consume_message_from_arbitrary_sender_public +160 ❌ +2.01%
CardGame::on_cards_claimed +120 ❌ +1.64%
Test::consume_mint_to_public_message +180 ❌ +1.62%
AvmTest::pedersen_commit +20 ❌ +1.62%
Test::public_dispatch +300 ❌ +1.47%
TokenBridge::claim_public +180 ❌ +1.39%
AvmTest::bulk_testing +280 ❌ +1.18%
Uniswap::swap_public +180 ❌ +1.14%
TestLog::emit_unencrypted_events +20 ❌ +1.07%
TokenBridge::exit_to_l1_public +80 ❌ +1.00%
TokenBridge::public_dispatch +220 ❌ +0.99%
CardGame::on_game_joined +40 ❌ +0.79%
AvmTest::keccak_hash +20 ❌ +0.73%
Uniswap::public_dispatch +180 ❌ +0.72%
CardGame::on_card_played +40 ❌ +0.67%
AvmTest::public_dispatch +380 ❌ +0.62%
AvmTest::sha256_hash +20 ❌ +0.51%
Full diff report 👇
Program Bytecode size in bytes (+/-) %
Test::create_l2_to_l1_message_public 2,202 (+160) +7.84%
AvmTest::pedersen_hash 3,095 (+160) +5.45%
AvmTest::pedersen_hash_with_index 3,095 (+160) +5.45%
CardGame::start_game 7,165 (+200) +2.87%
CardGame::public_dispatch 16,643 (+400) +2.46%
Test::consume_message_from_arbitrary_sender_public 8,137 (+160) +2.01%
CardGame::on_cards_claimed 7,458 (+120) +1.64%
Test::consume_mint_to_public_message 11,284 (+180) +1.62%
AvmTest::pedersen_commit 1,255 (+20) +1.62%
Test::public_dispatch 20,664 (+300) +1.47%
TokenBridge::claim_public 13,136 (+180) +1.39%
AvmTest::bulk_testing 24,075 (+280) +1.18%
Uniswap::swap_public 15,903 (+180) +1.14%
TestLog::emit_unencrypted_events 1,885 (+20) +1.07%
TokenBridge::exit_to_l1_public 8,076 (+80) +1.00%
TokenBridge::public_dispatch 22,412 (+220) +0.99%
CardGame::on_game_joined 5,086 (+40) +0.79%
AvmTest::keccak_hash 2,769 (+20) +0.73%
Uniswap::public_dispatch 25,256 (+180) +0.72%
CardGame::on_card_played 5,987 (+40) +0.67%
AvmTest::public_dispatch 61,741 (+380) +0.62%
AvmTest::sha256_hash 3,910 (+20) +0.51%

aakoshh
aakoshh approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@aakoshh aakoshh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Link to the original: noir-lang/noir#6513

@TomAFrench TomAFrench merged commit db6fdc2 into master Nov 18, 2024
66 checks passed
@TomAFrench TomAFrench deleted the tf/pull-out-array-set-changes branch November 18, 2024 18:15
@AztecBot AztecBot mentioned this pull request Nov 18, 2024
Merged
TomAFrench added a commit that referenced this pull request Nov 19, 2024
@TomAFrench
Merge branch 'master' into tf/evaluator-changes
afda45d 
* master: (67 commits)
  chore: Fix bad merge on AztecLMDBStore initializer
  feat: add persisted database of proving jobs (#9942)
  chore: Clean up data configuration (#9973)
  chore: remove public kernels (#10027)
  chore: misc cleanup, docs and renaming (#9968)
  feat: IPA Accumulator in Builder (#9846)
  chore(docs): Updates to token contract (#9954)
  test(avm): minor benchmarking (#9869)
  chore(ci): run `l1-contracts` CI in parallel with `build` step (#10024)
  chore: build acir test programs in parallel to e2e build step (#9988)
  chore: pull out `array_set` pass changes (#9993)
  feat(avm): ephemeral avm tree (#9798)
  fix: don't take down runners with faulty runner check (#10019)
  feat(docs): add transaction profiler docs (#9932)
  chore: hotfix runner wait (#10018)
  refactor: remove EnqueuedCallSimulator (#10015)
  refactor: stop calling public kernels (#9971)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  ...
@AztecBot AztecBot mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aakoshh aakoshh aakoshh approved these changes

@vezenovm vezenovm Awaiting requested review from vezenovm

@jfecher jfecher Awaiting requested review from jfecher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @aakoshh