chore: World state tech debt cleanup 1 #9561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludamad
reviewed
Oct 30, 2024
| @@ -941,14 +969,22 @@ void ContentAddressedCachedTreeStore<LeafValueType>::remove_historical_block(con | |||
| get_meta(uncommittedMeta, *tx, true); | |||
| get_meta(committedMeta, *tx, false); | |||
| if (blockNumber != committedMeta.oldestHistoricBlock) { | |||
| throw std::runtime_error("Block number is not the most historic"); | |||
| throw std::runtime_error( | |||
There was a problem hiding this comment.
This formatting could have a small utility func
There was a problem hiding this comment.
Woops sorry hit merge by accident
There was a problem hiding this comment.
Used the pre-existing format function
…ec-packages into pw/world-state-cleanup
Changes to public function bytecode sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
TomAFrench
added a commit
that referenced
this pull request
Nov 18, 2024
* master: (281 commits) fix: don't take down runners with faulty runner check (#10019) feat(docs): add transaction profiler docs (#9932) chore: hotfix runner wait (#10018) refactor: remove EnqueuedCallSimulator (#10015) refactor: stop calling public kernels (#9971) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg chore: drop info to verbose in sequencer hot loop (#9983) refactor: Trace structure is an object (#10003) refactor: enqueued calls processor -> public tx simulator (#9919) chore: World state tech debt cleanup 1 (#9561) chore(ci): run noir tests in parallel to building e2e tests (#9977) Revert "chore: lower throughput of ebs disks" (#9996) feat: new proving broker implementation (#9400) chore: replace `to_radix` directive with brillig (#9970) chore: disable failing 48validator kind test (#9920) test: prove one epoch in kind (#9886) fix: formatting (#9979) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some tech debt cleanup within the world state module. We address:
#9508, #9509, #9510, #9511, #9513, #9516, #9517