Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): authwit note, not simulating simulations #9438

Merged
merged 11 commits into from
Nov 5, 2024

Conversation

critesjosh
Copy link
Contributor

@critesjosh critesjosh commented Oct 25, 2024

Adds notes to the docs that indicate that authwits only work in single player mode, describes the problems with not simulating simulations, and updates the bberg readme install instructions

closes AztecProtocol/dev-rel#422
closes AztecProtocol/dev-rel#433
closes #9256
closes AztecProtocol/dev-rel#423
closes #6865

@critesjosh critesjosh changed the title chore(docs): update authwit chore(docs): authwit note, not simulating simulations Oct 29, 2024
@critesjosh critesjosh marked this pull request as ready for review October 30, 2024 19:12
@AztecBot
Copy link
Collaborator

AztecBot commented Oct 30, 2024

Docs Preview

Hey there! 👋 You can check your preview at https://672a30cb499765aa9ea2edd2--aztec-docs-dev.netlify.app

@@ -194,6 +195,14 @@ The main difference is that we are not setting up an allowance, but allowing the

Also, most uses of the approvals are for contracts where the following interactions are called by the user themselves, so it is not a big issue that they are not as easily "transferrable" as the `permit`s.

:::note

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add this will change in future testnet launches

Copy link
Contributor

@rahul-kothari rahul-kothari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one minor commment. Should merge have nico is happy with the simulating simulation caveat

@critesjosh critesjosh enabled auto-merge (squash) November 4, 2024 20:21
@critesjosh critesjosh merged commit 1779c42 into master Nov 5, 2024
70 of 71 checks passed
@critesjosh critesjosh deleted the jc/docs-update branch November 5, 2024 14:53
Maddiaa0 pushed a commit that referenced this pull request Nov 6, 2024
Adds notes to the docs that indicate that authwits only work in single
player mode, describes the problems with not simulating simulations, and
updates the bberg readme install instructions

closes AztecProtocol/dev-rel#422
closes AztecProtocol/dev-rel#433
closes #9256
closes AztecProtocol/dev-rel#423
closes #6865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants