Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): finally isolate bb-native-tests #9039

Merged
merged 7 commits into from
Oct 7, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -305,24 +305,23 @@ jobs:
run: earthly-ci --no-output +preset-gcc

# barretenberg (prover) native, AVM (public VM) and Merkle tree (world state) tests
# only ran on x86 for resource reasons (memory intensive)
# ran on own runner for resource reasons (memory x cpu intensive)
bb-native-tests:
needs: [build, changes]
runs-on: ${{ github.event.pull_request.user.login || github.actor }}-x86
runs-on: ubuntu-20.04
needs: [build-images, changes]
if: needs.changes.outputs.barretenberg-cpp == 'true'
steps:
- uses: actions/checkout@v4
with: { ref: "${{ env.GIT_COMMIT }}" }
# Only allow one memory-hunger prover test to use this runner
- uses: ./.github/ci-setup-action
with:
# must be globally unique for build x runner
concurrency_key: bb-native-tests-x86
- name: "Native Prover Tests"
working-directory: ./barretenberg/cpp/
timeout-minutes: 40
# limit our parallelism to half our cores
run: earthly-ci --exec-stats --no-output +test --hardware_concurrency=64
uses: ./.github/ensure-tester
# note: tester by default times out at 30, would need to delay shutdwon for more
timeout-minutes: 30
with:
runner_type: 128core-tester-x86
run: |
scripts/earthly-ci --exec-stats --no-output +test --hardware_concurrency=64

bb-js-test:
needs: [build, changes]
Expand Down
2 changes: 1 addition & 1 deletion barretenberg/cpp/Earthfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
VERSION 0.8

# Note, this is only used on the main build path, caching test artifacts is less useful
# As those only run if there are changes anyway
# As those only run if there are changes anyway.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to force bb-native-tests to run

CACHE_BUILD_BIN:
FUNCTION
ARG command
Expand Down
Loading