Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] feat: contract entrypoint dispatch function #8726

Closed
wants to merge 15 commits into from

Conversation

asterite
Copy link
Contributor

Please read contributing guidelines and remove this line.

@asterite asterite requested a review from fcarreiro September 24, 2024 17:41

/// A trait for types that can be deserialized from a calldata field array
#[derive_via(derive_from_calldata)]
pub trait FromCalldata<let N: u32> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW when compiling all contracts I'm getting tons of "missing FromCalldata implementation" errors. IDK if it's feasible to reimplement all those.

error: No matching impl found for `EmbeddedCurvePoint: FromCalldata<_>`
   ┌─ contracts/token_contract/src/main.nr:14:3
   │
14 │ #[aztec]
   │   ----- No impl for `EmbeddedCurvePoint: FromCalldata<_>`
   │

error: No matching impl found for `str<31>: FromCalldata<_>`
   ┌─ contracts/token_contract/src/main.nr:14:3
   │
14 │ #[aztec]
   │   ----- No impl for `str<31>: FromCalldata<_>`
   │

error: Type annotation needed
  ┌─ contracts/auth_contract/src/main.nr:7:3
  │
7 │ #[aztec]
  │   ----- Could not determine type of generic argument
  │
  = Call stack:
    1. contracts/auth_contract/src/main.nr:7:3
 
...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I was just trying things on the avm test contract. I'll check all contracts and add the missing trait impls.

@fcarreiro
Copy link
Contributor

I'll start building on this because we are blocked and need to make progress.

Could you try to fix the stack overflow?

@asterite
Copy link
Contributor Author

Closed in favor of #8821

@asterite asterite closed this Sep 26, 2024
@asterite asterite deleted the ab/contract-entrypoint-dispatch branch September 26, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants