-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] feat: contract entrypoint dispatch function #8726
Conversation
noir-projects/noir-contracts/contracts/avm_test_contract/src/main.nr
Outdated
Show resolved
Hide resolved
noir-projects/noir-contracts/contracts/avm_test_contract/src/main.nr
Outdated
Show resolved
Hide resolved
…re are no public functions
|
||
/// A trait for types that can be deserialized from a calldata field array | ||
#[derive_via(derive_from_calldata)] | ||
pub trait FromCalldata<let N: u32> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if you can't use a Reader instead of having to define all these: https://github.com/AztecProtocol/aztec-packages/blob/master/noir-projects/noir-protocol-circuits/crates/types/src/utils/reader.nr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW when compiling all contracts I'm getting tons of "missing FromCalldata implementation" errors. IDK if it's feasible to reimplement all those.
error: No matching impl found for `EmbeddedCurvePoint: FromCalldata<_>`
┌─ contracts/token_contract/src/main.nr:14:3
│
14 │ #[aztec]
│ ----- No impl for `EmbeddedCurvePoint: FromCalldata<_>`
│
error: No matching impl found for `str<31>: FromCalldata<_>`
┌─ contracts/token_contract/src/main.nr:14:3
│
14 │ #[aztec]
│ ----- No impl for `str<31>: FromCalldata<_>`
│
error: Type annotation needed
┌─ contracts/auth_contract/src/main.nr:7:3
│
7 │ #[aztec]
│ ----- Could not determine type of generic argument
│
= Call stack:
1. contracts/auth_contract/src/main.nr:7:3
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I was just trying things on the avm test contract. I'll check all contracts and add the missing trait impls.
I'll start building on this because we are blocked and need to make progress. Could you try to fix the stack overflow? |
Closed in favor of #8821 |
Please read contributing guidelines and remove this line.