833 - Skip validation of the membership for optimistic read requests #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanmon
force-pushed
the
jm/833-pending-comm-skip-check
branch
from
87b3bed to
22736c5
Compare
dbanks12
approved these changes
Jun 15, 2023
Comment on lines
+85
to
+90
| // A pending commitment is the one that is not yet added to private data tree | ||
| // An optimistic read is when we try to "read" a pending commitment | ||
| // We determine if it is an optimistic read depending on the leaf index from the membership witness | ||
| // Note that the Merkle membership proof would be null and void in case of an optimistic read | ||
| // but we use the leaf index as a placeholder to detect an optimistic read. | ||
| const auto is_optimistic_read = (witness.leaf_index == NT::fr(-1)); |
circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit.test.cpp
Outdated
Show resolved
Hide resolved
circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit.test.cpp
Show resolved
Hide resolved
jeanmon
force-pushed
the
jm/833-pending-comm-skip-check
branch
from
47bb5e0 to
b778d9e
Compare
jeanmon
force-pushed
the
jm/833-pending-comm-skip-check
branch
from
b778d9e to
06c3b7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #833
Checklist: