Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle proofs for blocks submitted out of range #8357

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

spalladino
Copy link
Collaborator

prover-stats was throwing an error when querying with a start-block that was not the start of the chain, since it'd look up for the submission time of the L2 block for a proof, but would not find it because it was out of range.

@spalladino spalladino merged commit 9934adb into provernet Sep 3, 2024
3 checks passed
@spalladino spalladino deleted the palla/fix-stats branch September 3, 2024 16:48
@AztecBot
Copy link
Collaborator

AztecBot commented Sep 3, 2024

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256_ms 5,762 1,556 704 757 (+2%) 779 (+2%)
proof_construction_time_sha256_30_ms 11,903 3,195 (+1%) 1,417 (-1%) 1,445 1,476
proof_construction_time_sha256_100_ms 45,600 (+1%) 11,915 (-1%) 5,450 (+1%) 5,429 5,478 (+2%)
proof_construction_time_poseidon_hash_ms 78.0 34.0 34.0 58.0 (-2%) 88.0 (+1%)
proof_construction_time_poseidon_hash_30_ms 1,532 422 202 221 (-3%) 267
proof_construction_time_poseidon_hash_100_ms 5,652 1,509 680 731 748

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 4 txs 8 txs 16 txs
l1_rollup_calldata_size_in_bytes 4,324 7,844 14,852
l1_rollup_calldata_gas 49,720 92,464 177,560
l1_rollup_execution_gas 1,383,161 2,130,873 3,958,008
l2_block_processing_time_in_ms 255 (+2%) 439 (-2%) 815 (-1%)
l2_block_building_time_in_ms 9,202 17,959 35,832
l2_block_rollup_simulation_time_in_ms 9,201 17,959 35,832
l2_block_public_tx_process_time_in_ms 7,762 16,401 34,268

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 2,946 (-2%) 3,835
node_database_size_in_bytes 12,685,392 (+1%) 16,687,184
pxe_database_size_in_bytes 16,254 26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms input_size_in_bytes output_size_in_bytes proving_time_in_ms
private-kernel-init 90.8 (-6%) 383 21,673 44,858 N/A
private-kernel-inner 167 (+2%) 686 (-1%) 72,309 45,005 N/A
private-kernel-reset-tiny 502 (+1%) 891 (+2%) 65,974 44,844 N/A
private-kernel-tail 208 163 (+1%) 50,728 52,256 N/A
base-parity 5.59 (+1%) N/A 160 96.0 N/A
root-parity 33.2 N/A 69,084 96.0 N/A
base-rollup 2,817 N/A 187,817 664 N/A
root-rollup 38.7 (+1%) N/A 54,525 716 N/A
public-kernel-setup 86.3 (-1%) N/A 103,760 71,222 N/A
public-kernel-app-logic 98.9 N/A 103,599 71,222 N/A
public-kernel-tail 572 N/A 409,190 16,414 N/A
private-kernel-reset-small 486 (-1%) N/A 66,085 45,629 N/A
private-kernel-tail-to-public 1,016 (-14%) 631 492,960 1,697 N/A
public-kernel-teardown 85.0 (-1%) N/A 104,005 71,222 N/A
merge-rollup 19.7 (+3%) N/A 35,742 664 N/A
undefined N/A N/A N/A N/A 72,025 (+8%)

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms
ContractClassRegisterer:register 1,344 11,731 340
ContractInstanceDeployer:deploy 1,408 11,731 18.3 (-1%)
MultiCallEntrypoint:entrypoint 1,920 11,731 423
FeeJuice:deploy 1,376 11,731 386
SchnorrAccount:constructor 1,312 11,731 104 (-1%)
SchnorrAccount:entrypoint 2,304 11,731 433 (+1%)
Token:privately_mint_private_note 1,280 11,731 140 (+1%)
FPC:fee_entrypoint_public 1,344 11,731 27.7 (+4%)
Token:transfer 1,312 11,731 280 (+5%)
Benchmarking:create_note 1,344 11,731 100
SchnorrAccount:verify_private_authwit 1,280 11,731 28.3 (+2%)
Token:unshield 1,376 11,731 585 (+3%)
FPC:fee_entrypoint_private 1,376 11,731 776 (+1%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function time_ms bytecode_size_in_bytes
FeeJuice:_increase_public_balance 55.4 (+5%) 8,139
FeeJuice:set_portal 11.0 (+16%) 2,362
Token:constructor 84.1 (+3%) 31,107
FPC:constructor 53.5 22,380
FeeJuice:mint_public 38.1 (+1%) 6,150
Token:mint_public 42.8 (+1%) 11,720
Token:assert_minter_and_mint 66.5 (-1%) 8,028
AuthRegistry:set_authorized 37.8 (+6%) 4,537
FPC:prepare_fee 244 (+4%) 8,812
Token:transfer_public 19.8 (-16%) 47,358
FPC:pay_refund 54.8 (-1%) 12,082
Benchmarking:increment_balance 959 7,450
Token:_increase_public_balance 43.5 (+13%) 8,960
FPC:pay_refund_with_shielded_rebate 69.8 (+4%) 12,631

Public DB Access

Time to access various public DBs.

Function time_ms
get-nullifier-index 0.164

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 256 leaves 512 leaves 1024 leaves
batch_insert_into_append_only_tree_16_depth_ms 2.24 (+3%) 3.90 (+2%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.7 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.116 (+3%) 0.109 (+1%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 11.5 17.6 (-4%) 31.3 (+1%) 59.3 (-1%) 114 (+1%)
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 287 543 1,055
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.110 0.102 (-4%) 0.101 (+2%) 0.102 (-1%) 0.102 (+1%)
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 14.5 25.5 (-3%) 44.3 (+1%) 82.3 (-2%) 163 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 109 207 355 691 1,363
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.110 (-1%) 0.103 (-3%) 0.107 (+2%) 0.102 (-2%) 0.103 (+1%)
batch_insert_into_indexed_tree_40_depth_ms N/A N/A 16.4 (-1%) N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A 132 N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A 0.105 (-1%) N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 64,779 668,997

Transaction size based on fee payment method

| Metric | |
| - | |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants