chore(p2p): tx serialization cleanup

[Maddiaa0]

Overview

The extra serialization methods mainly added lengths to buffers, however this already takes place in the nested objects
using the existing serde methods (toBuffer, fromBuffer) appears to yield the same result

[Maddiaa0]

• chore(p2p): tx serialization cleanup #7620 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Maddiaa0 and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (FPC:pay_refund): 81.6 (-37%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,708 (-1%)	1,547 (-1%)	701 (-1%)	762 (+4%)	772 (+1%)
proof_construction_time_sha256_30_ms	11,762 (-1%)	3,138 (-4%)	1,412 (-1%)	1,432	1,463 (-1%)
proof_construction_time_sha256_100_ms	43,850 (-1%)	11,813 (-3%)	5,431 (-1%)	5,423	5,347 (-1%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	58.0 (-2%)	88.0 (+1%)
proof_construction_time_poseidon_hash_30_ms	1,517 (-1%)	419 (-1%)	201	224 (-1%)	266 (-2%)
proof_construction_time_poseidon_hash_100_ms	5,619	1,523	678 (+1%)	720 (-5%)	744

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	708	708	708
l1_rollup_calldata_gas	6,588	6,592	6,588
l1_rollup_execution_gas	584,268	584,423	584,570
l2_block_processing_time_in_ms	758	1,416 (-2%)	2,687 (-5%)
l2_block_building_time_in_ms	10,830	21,009 (-1%)	42,004 (+1%)
l2_block_rollup_simulation_time_in_ms	10,830	21,009 (-1%)	42,003 (+1%)
l2_block_public_tx_process_time_in_ms	9,040	19,050 (-1%)	39,894 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,051 (-4%)	9,840
node_database_size_in_bytes	12,750,928	16,900,176
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	104 (-2%)	411	21,310	53,089	N/A	N/A	N/A	N/A
private-kernel-inner	186 (-3%)	712 (-2%)	79,930	53,265	N/A	N/A	N/A	N/A
private-kernel-tail	449 (-2%)	884 (-2%)	60,700	57,446	N/A	N/A	N/A	N/A
base-parity	6.41 (-1%)	688 (-4%)	160	96.0	1,987 (-2%)	13,188	19.0	131,072
root-parity	108 (-1%)	139 (+14%)	66,908	96.0	30,179 (-6%)	13,188	19.0	4,194,304
base-rollup	3,396 (-1%)	4,822 (-6%)	181,595	632	43,897 (-2%)	13,988	44.0	4,194,304
root-rollup	153	125 (+2%)	52,797	652	27,913 (-1%)	13,924	42.0	4,194,304
public-kernel-setup	113 (-4%)	2,731 (-1%)	112,376	80,246	17,725 (-3%)	141,444	4,027	2,097,152
public-kernel-app-logic	120 (-1%)	3,969 (-2%)	112,376	80,246	11,079 (-1%)	141,444	4,027	1,048,576
public-kernel-tail	633 (-1%)	26,229 (-5%)	410,117	10,814	65,773 (-3%)	26,372	431	8,388,608
private-kernel-reset-tiny	231 (-1%)	881 (-3%)	76,064	52,960	N/A	N/A	N/A	N/A
private-kernel-tail-to-public	5,181 (-3%)	1,577 (-2%)	900,567	1,632	N/A	N/A	N/A	N/A
public-kernel-teardown	100 (-9%)	3,901 (-3%)	112,376	80,246	18,791 (-2%)	141,444	4,027	2,097,152
merge-rollup	58.6	N/A	34,590	632	N/A	N/A	N/A	N/A
undefined	N/A	N/A	N/A	N/A	155,900	N/A	N/A	N/A

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms
ContractClassRegisterer:register	1,312	11,699	343 (-1%)	N/A	N/A
ContractInstanceDeployer:deploy	1,376	11,699	27.4 (-1%)	N/A	N/A
MultiCallEntrypoint:entrypoint	1,888	11,699	603 (-2%)	N/A	N/A
GasToken:deploy	1,344	11,699	433 (-3%)	N/A	N/A
SchnorrAccount:constructor	1,280	11,699	427	N/A	N/A
SchnorrAccount:entrypoint	2,272	11,699	816	N/A	N/A
Token:privately_mint_private_note	1,248	11,699	496 (-3%)	N/A	N/A
FPC:fee_entrypoint_public	1,312	11,699	87.9 (-3%)	N/A	N/A
Token:transfer	1,280	11,699	1,310	N/A	N/A
AuthRegistry:set_authorized (avm)	21,702	N/A	N/A	102,048	2,157 (-1%)
FPC:prepare_fee (avm)	25,150	N/A	N/A	102,112	2,208 (-2%)
Token:transfer_public (avm)	58,188	N/A	N/A	102,112	6,412 (-4%)
AuthRegistry:consume (avm)	35,580	N/A	N/A	102,080	2,601 (-3%)
FPC:pay_refund (avm)	30,010	N/A	N/A	102,080	3,525 (-3%)
Benchmarking:create_note	1,312	11,699	420	N/A	N/A
SchnorrAccount:verify_private_authwit	1,248	11,699	44.1 (-16%)	N/A	N/A
Token:unshield	1,344	11,699	1,137 (+1%)	N/A	N/A
FPC:fee_entrypoint_private	1,344	11,699	1,424	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	98.9 (-2%)	13,790
GasToken:set_portal	14.2 (-22%)	3,339
Token:constructor	122 (+26%)	23,692
FPC:constructor	90.5 (-2%)	13,592
GasToken:mint_public	82.9 (-2%)	10,158
Token:mint_public	300 (-3%)	19,034
Token:assert_minter_and_mint	61.5 (-27%)	12,925
AuthRegistry:set_authorized	47.3 (-1%)	7,812
FPC:prepare_fee	252	11,068
Token:transfer_public	50.4 (-5%)	44,012
FPC:pay_refund	⚠️ 81.6 (-37%)	15,961
Benchmarking:increment_balance	1,058	11,281
Token:_increase_public_balance	15.0 (-1%)	15,006
FPC:pay_refund_with_shielded_rebate	135	17,056

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.158 (-3%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4	16.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.599	0.514	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.0 (-3%)	75.4 (-6%)	132 (+1%)	244	471 (-6%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.490 (-3%)	0.463 (-6%)	0.453	0.443	0.439 (-6%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	59.9	111 (-2%)	183	351 (-3%)	692 (-2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.506	0.498 (-2%)	0.485	0.476 (-3%)	0.475 (-1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	72.5 (-2%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.516 (-2%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	72,014	666,910

Transaction size based on fee payment method

| Metric | |
| - | |