-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add gate profiler for noir circuits #7004
Merged
Merged
Changes from 25 commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
f6d65af
initial version of reporter of gates
sirasistant 14aa792
amortising table gates over all opcodes which use the table... ish
iAmMichaelConnor 455dcbb
feat: flamegraph generator
sirasistant 1b7753e
Merge branch 'arv/flamegraph_acir' of github.com:AztecProtocol/aztec-…
sirasistant 7a20a94
Revert "amortising table gates over all opcodes which use the table..…
sirasistant 319c980
it's workiiiiiiiiing
sirasistant 64453b8
Reapply "amortising table gates over all opcodes which use the table.…
iAmMichaelConnor fc7b22a
better spreading
iAmMichaelConnor 5da2664
try again... it's over-computing gates
iAmMichaelConnor 159605d
and again...
iAmMichaelConnor 1ba3b38
flamegraph options
sirasistant db6db28
Merge branch 'arv/flamegraph_acir' of github.com:AztecProtocol/aztec-…
sirasistant 0b3d59e
remove simple test
sirasistant 987c683
add smol script for extract a contract function as a regular artifact
sirasistant 15f2c2b
refactor create flamegraph cmd
sirasistant e98efed
remove some extraneous boilerplate
sirasistant 12b9c17
rename
sirasistant 75885c8
update help
sirasistant 2456442
simplify bb changes to gate counter
sirasistant c6d0e77
refactoring
sirasistant 3180711
preparing for PR
sirasistant 0a18f3a
build profiler bin
sirasistant dba410e
move script
sirasistant 12370a7
print the path written in extractor
sirasistant a932bb1
update tests
sirasistant 073039d
refactor: extract to a mock file
sirasistant aab0497
Merge branch 'master' into arv/flamegraph_acir
sirasistant 553272a
update comment
sirasistant f1f2743
Merge branch 'arv/flamegraph_acir' of github.com:AztecProtocol/aztec-…
sirasistant f2eec54
conditional gate counting
sirasistant 62b41e6
Merge branch 'master' into arv/flamegraph_acir
ludamad a48d748
better resizing
sirasistant 86e008e
better conditioning of the gate tracking
sirasistant 6f1a07e
use imported line and column helper
sirasistant 7e778b2
add test
sirasistant ea459c7
fix: frame separator
sirasistant 1137d53
rename binary
sirasistant 2c361db
fix extraneous naming
sirasistant 36f9b66
Merge branch 'master' into arv/flamegraph_acir
sirasistant b1a71e1
fmt
sirasistant 1f48133
review changes
sirasistant 5093fdd
fmt
sirasistant 83293cc
Merge branch 'master' into arv/flamegraph_acir
sirasistant ead7db9
restore initializers
sirasistant 66026fd
add initializer for gates per opcode
sirasistant d3f231c
address rust pr comments
sirasistant ba784f5
more pr comment addressing
sirasistant 9cc4691
gcc constructors...
sirasistant b387e18
Merge branch 'master' into arv/flamegraph_acir
sirasistant 7ae3e34
refactor: use debug artifact instead of implementing files
sirasistant f26fdfa
Merge branch 'master' into arv/flamegraph_acir
sirasistant ebe4985
revert formatting change
sirasistant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
167 changes: 134 additions & 33 deletions
167
barretenberg/cpp/src/barretenberg/dsl/acir_format/acir_format.cpp
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to be explicit on == ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I didn't do this the parent struct complains about
Explicitly defaulted equality comparison operator is implicitly deletedclang(-Wdefaulted-function-deleted)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDK why the parent is explicit though