Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cpp cache and add other e2e #5512

Merged
merged 62 commits into from
Mar 30, 2024
Merged

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Mar 28, 2024

  • fix cpp make timestamps. Investigated ccache but while elegant, it hurt non-cached builds too much seemingly
  • enable rest of e2e tests, commenting out ones that didn't work (TODO look into or would appreciate eyes but would like this in to get mostly covered)
  • e2e tests use earthly ls to read the targets

@AztecBot
Copy link
Collaborator

AztecBot commented Mar 28, 2024

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 40202813 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 676 676 676
l1_rollup_calldata_gas 6,424 6,400 6,400
l1_rollup_execution_gas 585,757 585,733 585,733
l2_block_processing_time_in_ms 1,251 (-3%) 4,686 (-4%) 8,833 (-4%)
note_successful_decrypting_time_in_ms 249 (-8%) 564 (+4%) 941 (-3%)
note_trial_decrypting_time_in_ms 53.0 (-33%) 84.9 (+32%) 69.2 (-34%)
l2_block_building_time_in_ms 12,176 43,165 (-3%) 88,154
l2_block_rollup_simulation_time_in_ms 7,574 (+2%) 24,998 (-4%) 50,856
l2_block_public_tx_process_time_in_ms 4,582 (-3%) 18,121 (-2%) 37,203

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 14,288 (-2%) 27,574 (+1%)
note_history_successful_decrypting_time_in_ms 1,275 (-1%) 2,442 (+1%)
note_history_trial_decrypting_time_in_ms 87.1 143 (+27%)
node_database_size_in_bytes 18,657,360 35,115,088 (+1%)
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 181 (-1%) 44,379 28,214
private-kernel-ordering 168 (-1%) 52,880 14,296
base-parity 3,640 (+8%) 128 311
root-parity 1,266 (-3%) 1,244 311
base-rollup 14,780 (-1%) 165,760 861
root-rollup 49.1 4,359 725
private-kernel-inner 226 73,795 28,214
public-kernel-app-logic 95.1 35,252 28,217
public-kernel-tail 139 (+1%) 40,928 28,217
merge-rollup 8.16 (+1%) 2,568 861
public-kernel-teardown 92.5 35,252 28,217
public-kernel-setup 91.2 35,252 28,217

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 9.98 16.0 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.582 0.495 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 46.7 (+1%) 72.9 (+1%) 230 (-1%) 450 865 (-1%) 1,726 (-1%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.480 (+1%) 0.449 (+1%) 0.419 (-1%) 0.421 (+1%) 0.410 (-1%) 0.414 N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 54.7 (-2%) 105 (-1%) 327 (-3%) 662 1,270 (-3%) 2,539 (-3%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 105 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.482 (-2%) 0.476 (-1%) 0.446 (-3%) 0.456 0.441 (-3%) 0.441 (-4%) N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 61.6 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.538 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 14,968 495,320

Transaction size based on fee payment method

Metric none fee payment method native fee payment method fpc_public fee payment method fpc_private fee payment method
tx_with_fee_size_in_bytes 773 905 1,161 1,377

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms 1,778 (-1%) 1,191 (-1%) 5,721 (+1%)
Metric 0 public data writes 1 public data writes 2 public data writes 3 public data writes 4 public data writes 5 public data writes 8 public data writes
tx_sequencer_processing_time_ms 12.4 (+6%) 577 446 (+1%) 1,175 598 (+1%) 2,037 566

@ludamad ludamad requested a review from charlielye March 29, 2024 02:17
@ludamad ludamad requested a review from TomAFrench March 29, 2024 17:16
@ludamad ludamad enabled auto-merge (squash) March 29, 2024 17:16
@ludamad
Copy link
Collaborator Author

ludamad commented Mar 30, 2024

@charlielye mind reviewing?

@ludamad ludamad merged commit 4118bcd into master Mar 30, 2024
148 checks passed
@ludamad ludamad deleted the ad/fix-cpp-cache-and-add-other-e2e branch March 30, 2024 17:54
rahul-kothari pushed a commit that referenced this pull request Apr 2, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.32.1</summary>

##
[0.32.1](aztec-package-v0.32.0...aztec-package-v0.32.1)
(2024-04-02)


### Miscellaneous

* Explicit type imports
([#5519](#5519))
([2a217de](2a217de))
</details>

<details><summary>barretenberg.js: 0.32.1</summary>

##
[0.32.1](barretenberg.js-v0.32.0...barretenberg.js-v0.32.1)
(2024-04-02)


### Features

* Earthly split runners, structure reverts
([#5524](#5524))
([fcb8787](fcb8787))


### Bug Fixes

* **ci:** Turn on earthly for everyone
([#5423](#5423))
([bea3fcb](bea3fcb))
</details>

<details><summary>aztec-cli: 0.32.1</summary>

##
[0.32.1](aztec-cli-v0.32.0...aztec-cli-v0.32.1)
(2024-04-02)


### Miscellaneous

* Explicit type imports
([#5519](#5519))
([2a217de](2a217de))
</details>

<details><summary>aztec-packages: 0.32.1</summary>

##
[0.32.1](aztec-packages-v0.32.0...aztec-packages-v0.32.1)
(2024-04-02)


### Features

* **acir_gen:** Fold attribute at compile-time and initial non inlined
ACIR
([#5341](#5341))
([a979150](a979150))
* **acvm:** Execute multiple circuits
([#5380](#5380))
([bb71920](bb71920))
* Dont double check num bits in brillig vm
([#5489](#5489))
([a18288d](a18288d))
* Earthly split runners, structure reverts
([#5524](#5524))
([fcb8787](fcb8787))
* Parallel gtest
([#5498](#5498))
([349ea59](349ea59))


### Bug Fixes

* **ci:** Turn on earthly for everyone
([#5423](#5423))
([bea3fcb](bea3fcb))
* Cpp cache and add other e2e
([#5512](#5512))
([4118bcd](4118bcd))
* Require noir-packages-test to finish
([#5505](#5505))
([191f0df](191f0df))
* Univariate evals not set in ECCVM prover
([#5529](#5529))
([f9a2b7c](f9a2b7c))


### Miscellaneous

* Add goblin ops in add_gates_to_ensure_all_polys_are_non_zero
([#5468](#5468))
([b9041e4](b9041e4))
* **avm:** Add 15 additional 16-bit registers in ALU trace of AVM
circuit
([#5503](#5503))
([8725c39](8725c39))
* **avm:** Migrate memory data structure in AVM circuit to unordered map
([#5506](#5506))
([ccd09aa](ccd09aa))
* Build contracts and protocol circuits sequentially if not enough ram
([#5499](#5499))
([ea072b6](ea072b6))
* Bye bye shared ptrs for ultra/goblin ultra proving_keys :)
([#5407](#5407))
([b94d0db](b94d0db))
* Clean up compute_next_accumulator
([#5516](#5516))
([f9be2f2](f9be2f2))
* Explicit type imports
([#5519](#5519))
([2a217de](2a217de))
* Improve caching in noir Earthfile
([#5513](#5513))
([5d1fb44](5d1fb44))
* Inject fetcher instead of using global
([#5502](#5502))
([a066544](a066544))
* Make get notes return all notes at beginning of array
[#4991](#4991)
([#5321](#5321))
([5c5b627](5c5b627))
* Move alphas generation to oink
([#5515](#5515))
([3b964f3](3b964f3))
* Replace relative paths to noir-protocol-circuits
([a689e4e](a689e4e))
* Replace relative paths to noir-protocol-circuits
([db1bab5](db1bab5))
* Replace relative paths to noir-protocol-circuits
([b2ab64b](b2ab64b))
* Replace relative paths to noir-protocol-circuits
([1f468db](1f468db))
* Run nargo format for noir-projects
([#5483](#5483))
([277168f](277168f))
</details>

<details><summary>barretenberg: 0.32.1</summary>

##
[0.32.1](barretenberg-v0.32.0...barretenberg-v0.32.1)
(2024-04-02)


### Features

* **acvm:** Execute multiple circuits
([#5380](#5380))
([bb71920](bb71920))
* Earthly split runners, structure reverts
([#5524](#5524))
([fcb8787](fcb8787))
* Parallel gtest
([#5498](#5498))
([349ea59](349ea59))


### Bug Fixes

* **ci:** Turn on earthly for everyone
([#5423](#5423))
([bea3fcb](bea3fcb))
* Cpp cache and add other e2e
([#5512](#5512))
([4118bcd](4118bcd))
* Univariate evals not set in ECCVM prover
([#5529](#5529))
([f9a2b7c](f9a2b7c))


### Miscellaneous

* Add goblin ops in add_gates_to_ensure_all_polys_are_non_zero
([#5468](#5468))
([b9041e4](b9041e4))
* **avm:** Add 15 additional 16-bit registers in ALU trace of AVM
circuit
([#5503](#5503))
([8725c39](8725c39))
* **avm:** Migrate memory data structure in AVM circuit to unordered map
([#5506](#5506))
([ccd09aa](ccd09aa))
* Bye bye shared ptrs for ultra/goblin ultra proving_keys :)
([#5407](#5407))
([b94d0db](b94d0db))
* Clean up compute_next_accumulator
([#5516](#5516))
([f9be2f2](f9be2f2))
* Move alphas generation to oink
([#5515](#5515))
([3b964f3](3b964f3))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Apr 3, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-package: 0.32.1</summary>

##
[0.32.1](AztecProtocol/aztec-packages@aztec-package-v0.32.0...aztec-package-v0.32.1)
(2024-04-02)


### Miscellaneous

* Explicit type imports
([#5519](AztecProtocol/aztec-packages#5519))
([2a217de](AztecProtocol/aztec-packages@2a217de))
</details>

<details><summary>barretenberg.js: 0.32.1</summary>

##
[0.32.1](AztecProtocol/aztec-packages@barretenberg.js-v0.32.0...barretenberg.js-v0.32.1)
(2024-04-02)


### Features

* Earthly split runners, structure reverts
([#5524](AztecProtocol/aztec-packages#5524))
([fcb8787](AztecProtocol/aztec-packages@fcb8787))


### Bug Fixes

* **ci:** Turn on earthly for everyone
([#5423](AztecProtocol/aztec-packages#5423))
([bea3fcb](AztecProtocol/aztec-packages@bea3fcb))
</details>

<details><summary>aztec-cli: 0.32.1</summary>

##
[0.32.1](AztecProtocol/aztec-packages@aztec-cli-v0.32.0...aztec-cli-v0.32.1)
(2024-04-02)


### Miscellaneous

* Explicit type imports
([#5519](AztecProtocol/aztec-packages#5519))
([2a217de](AztecProtocol/aztec-packages@2a217de))
</details>

<details><summary>aztec-packages: 0.32.1</summary>

##
[0.32.1](AztecProtocol/aztec-packages@aztec-packages-v0.32.0...aztec-packages-v0.32.1)
(2024-04-02)


### Features

* **acir_gen:** Fold attribute at compile-time and initial non inlined
ACIR
([#5341](AztecProtocol/aztec-packages#5341))
([a979150](AztecProtocol/aztec-packages@a979150))
* **acvm:** Execute multiple circuits
([#5380](AztecProtocol/aztec-packages#5380))
([bb71920](AztecProtocol/aztec-packages@bb71920))
* Dont double check num bits in brillig vm
([#5489](AztecProtocol/aztec-packages#5489))
([a18288d](AztecProtocol/aztec-packages@a18288d))
* Earthly split runners, structure reverts
([#5524](AztecProtocol/aztec-packages#5524))
([fcb8787](AztecProtocol/aztec-packages@fcb8787))
* Parallel gtest
([#5498](AztecProtocol/aztec-packages#5498))
([349ea59](AztecProtocol/aztec-packages@349ea59))


### Bug Fixes

* **ci:** Turn on earthly for everyone
([#5423](AztecProtocol/aztec-packages#5423))
([bea3fcb](AztecProtocol/aztec-packages@bea3fcb))
* Cpp cache and add other e2e
([#5512](AztecProtocol/aztec-packages#5512))
([4118bcd](AztecProtocol/aztec-packages@4118bcd))
* Require noir-packages-test to finish
([#5505](AztecProtocol/aztec-packages#5505))
([191f0df](AztecProtocol/aztec-packages@191f0df))
* Univariate evals not set in ECCVM prover
([#5529](AztecProtocol/aztec-packages#5529))
([f9a2b7c](AztecProtocol/aztec-packages@f9a2b7c))


### Miscellaneous

* Add goblin ops in add_gates_to_ensure_all_polys_are_non_zero
([#5468](AztecProtocol/aztec-packages#5468))
([b9041e4](AztecProtocol/aztec-packages@b9041e4))
* **avm:** Add 15 additional 16-bit registers in ALU trace of AVM
circuit
([#5503](AztecProtocol/aztec-packages#5503))
([8725c39](AztecProtocol/aztec-packages@8725c39))
* **avm:** Migrate memory data structure in AVM circuit to unordered map
([#5506](AztecProtocol/aztec-packages#5506))
([ccd09aa](AztecProtocol/aztec-packages@ccd09aa))
* Build contracts and protocol circuits sequentially if not enough ram
([#5499](AztecProtocol/aztec-packages#5499))
([ea072b6](AztecProtocol/aztec-packages@ea072b6))
* Bye bye shared ptrs for ultra/goblin ultra proving_keys :)
([#5407](AztecProtocol/aztec-packages#5407))
([b94d0db](AztecProtocol/aztec-packages@b94d0db))
* Clean up compute_next_accumulator
([#5516](AztecProtocol/aztec-packages#5516))
([f9be2f2](AztecProtocol/aztec-packages@f9be2f2))
* Explicit type imports
([#5519](AztecProtocol/aztec-packages#5519))
([2a217de](AztecProtocol/aztec-packages@2a217de))
* Improve caching in noir Earthfile
([#5513](AztecProtocol/aztec-packages#5513))
([5d1fb44](AztecProtocol/aztec-packages@5d1fb44))
* Inject fetcher instead of using global
([#5502](AztecProtocol/aztec-packages#5502))
([a066544](AztecProtocol/aztec-packages@a066544))
* Make get notes return all notes at beginning of array
[#4991](AztecProtocol/aztec-packages#4991)
([#5321](AztecProtocol/aztec-packages#5321))
([5c5b627](AztecProtocol/aztec-packages@5c5b627))
* Move alphas generation to oink
([#5515](AztecProtocol/aztec-packages#5515))
([3b964f3](AztecProtocol/aztec-packages@3b964f3))
* Replace relative paths to noir-protocol-circuits
([a689e4e](AztecProtocol/aztec-packages@a689e4e))
* Replace relative paths to noir-protocol-circuits
([db1bab5](AztecProtocol/aztec-packages@db1bab5))
* Replace relative paths to noir-protocol-circuits
([b2ab64b](AztecProtocol/aztec-packages@b2ab64b))
* Replace relative paths to noir-protocol-circuits
([1f468db](AztecProtocol/aztec-packages@1f468db))
* Run nargo format for noir-projects
([#5483](AztecProtocol/aztec-packages#5483))
([277168f](AztecProtocol/aztec-packages@277168f))
</details>

<details><summary>barretenberg: 0.32.1</summary>

##
[0.32.1](AztecProtocol/aztec-packages@barretenberg-v0.32.0...barretenberg-v0.32.1)
(2024-04-02)


### Features

* **acvm:** Execute multiple circuits
([#5380](AztecProtocol/aztec-packages#5380))
([bb71920](AztecProtocol/aztec-packages@bb71920))
* Earthly split runners, structure reverts
([#5524](AztecProtocol/aztec-packages#5524))
([fcb8787](AztecProtocol/aztec-packages@fcb8787))
* Parallel gtest
([#5498](AztecProtocol/aztec-packages#5498))
([349ea59](AztecProtocol/aztec-packages@349ea59))


### Bug Fixes

* **ci:** Turn on earthly for everyone
([#5423](AztecProtocol/aztec-packages#5423))
([bea3fcb](AztecProtocol/aztec-packages@bea3fcb))
* Cpp cache and add other e2e
([#5512](AztecProtocol/aztec-packages#5512))
([4118bcd](AztecProtocol/aztec-packages@4118bcd))
* Univariate evals not set in ECCVM prover
([#5529](AztecProtocol/aztec-packages#5529))
([f9a2b7c](AztecProtocol/aztec-packages@f9a2b7c))


### Miscellaneous

* Add goblin ops in add_gates_to_ensure_all_polys_are_non_zero
([#5468](AztecProtocol/aztec-packages#5468))
([b9041e4](AztecProtocol/aztec-packages@b9041e4))
* **avm:** Add 15 additional 16-bit registers in ALU trace of AVM
circuit
([#5503](AztecProtocol/aztec-packages#5503))
([8725c39](AztecProtocol/aztec-packages@8725c39))
* **avm:** Migrate memory data structure in AVM circuit to unordered map
([#5506](AztecProtocol/aztec-packages#5506))
([ccd09aa](AztecProtocol/aztec-packages@ccd09aa))
* Bye bye shared ptrs for ultra/goblin ultra proving_keys :)
([#5407](AztecProtocol/aztec-packages#5407))
([b94d0db](AztecProtocol/aztec-packages@b94d0db))
* Clean up compute_next_accumulator
([#5516](AztecProtocol/aztec-packages#5516))
([f9be2f2](AztecProtocol/aztec-packages@f9be2f2))
* Move alphas generation to oink
([#5515](AztecProtocol/aztec-packages#5515))
([3b964f3](AztecProtocol/aztec-packages@3b964f3))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants