Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Intermittent invert 0 in Goblin #5174

Merged
merged 4 commits into from
Mar 13, 2024
Merged

fix: Intermittent invert 0 in Goblin #5174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
75a06c9
Revert "fix: Fix Translator composer test instability (#4751)"
codygunton Mar 12, 2024
fedf982
Fix intermitting scalar mul by 0
codygunton Mar 12, 2024
7e6b467
Append rather than prepend to deal with swapping
codygunton Mar 13, 2024
1956ed6
Reference todo that could simplify
codygunton Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions barretenberg/cpp/src/barretenberg/proof_system/op_queue/ecc_op_queue.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,19 @@ class ECCOpQueue {

std::array<Point, 4> ultra_ops_commitments;

// TODO(https://github.com/AztecProtocol/barretenberg/issues/905): Can remove this with better handling of scalar
// mul against 0
void append_nonzero_ops()
{
// Add an element and scalar the accumulation of which leaves no Point-at-Infinity commitments
const auto x = uint256_t(0xd3c208c16d87cfd3, 0xd97816a916871ca8, 0x9b85045b68181585, 0x30644e72e131a02);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these fixed values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rumata888

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-2*generator

const auto y = uint256_t(0x3ce1cc9c7e645a83, 0x2edac647851e3ac5, 0xd0cbe61fced2bc53, 0x1a76dae6d3272396);
auto padding_element = Point(x, y);
auto padding_scalar = -Fr::one();
mul_accumulate(padding_element, padding_scalar);
eq();
}

Point get_accumulator() { return accumulator; }

/**
Expand Down
3 changes: 3 additions & 0 deletions barretenberg/cpp/src/barretenberg/sumcheck/instance/prover_instance.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ template <class Flavor> class ProverInstance_ {
BB_OP_COUNT_TIME_NAME("ProverInstance(Circuit&)");
circuit.add_gates_to_ensure_all_polys_are_non_zero();
circuit.finalize_circuit();
if constexpr (IsGoblinFlavor<Flavor>) {
circuit.op_queue->append_nonzero_ops();
}

dyadic_circuit_size = compute_dyadic_size(circuit);

Expand Down
12 changes: 0 additions & 12 deletions barretenberg/cpp/src/barretenberg/translator_vm/goblin_translator_composer.test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,24 +49,12 @@ TEST_F(GoblinTranslatorComposerTests, Basic)
using Fr = fr;
using Fq = fq;

// Add an element and scalar the accumulation of which leaves no Point-at-Infinity commitments
const auto x = uint256_t(0xd3c208c16d87cfd3, 0xd97816a916871ca8, 0x9b85045b68181585, 0x30644e72e131a02);
const auto y = uint256_t(0x3ce1cc9c7e645a83, 0x2edac647851e3ac5, 0xd0cbe61fced2bc53, 0x1a76dae6d3272396);
auto padding_element = G1(x, y);
auto padding_scalar = -Fr::one();

auto P1 = G1::random_element();
auto P2 = G1::random_element();
auto z = Fr::random_element();

// Add the same operations to the ECC op queue; the native computation is performed under the hood.
auto op_queue = std::make_shared<bb::ECCOpQueue>();

// Accumulate padding so that we don't produce Point-at-Infinity commitments. Currently our transcript can't handle
// them
op_queue->mul_accumulate(padding_element, padding_scalar);

// Push everything else
for (size_t i = 0; i < 500; i++) {
op_queue->add_accumulate(P1);
op_queue->mul_accumulate(P2, z);
Expand Down
Loading