Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: incorrect comment #4846

Merged
merged 2 commits into from
Feb 29, 2024
Merged

docs: incorrect comment #4846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22a9729
docs: incorrect comment
benesjan Feb 28, 2024
d3a85d1
more fixes
benesjan Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions noir-projects/aztec-nr/aztec/src/history/nullifier_inclusion.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ fn _nullifier_inclusion(nullifier: Field, header: Header) {
== compute_merkle_root(nullifier_leaf, witness.index, witness.path), "Proving nullifier inclusion failed"
);
// --> Now we have traversed the trees all the way up to archive root and verified that the nullifier
// was not yet included in the nullifier tree.
// was included in the nullifier tree.
}

pub fn prove_nullifier_inclusion(nullifier: Field, context: PrivateContext) {
Expand All @@ -31,7 +31,7 @@ pub fn prove_nullifier_inclusion(nullifier: Field, context: PrivateContext) {

pub fn prove_nullifier_inclusion_at(
nullifier: Field,
block_number: u32, // The block at which we'll prove that the note exists
block_number: u32, // The block at which we'll prove that the nullifier exists in the nullifier tree
context: PrivateContext
) {
let header = context.get_header_at(block_number);
Expand Down
7 changes: 2 additions & 5 deletions noir-projects/noir-contracts/contracts/inclusion_proofs_contract/src/main.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,7 @@ contract InclusionProofs {
prove_nullifier_inclusion, prove_nullifier_inclusion_at, prove_note_is_nullified,
prove_note_is_nullified_at
},
nullifier_non_inclusion::{
prove_nullifier_not_included, prove_nullifier_not_included_at, prove_note_not_nullified,
prove_note_not_nullified_at
},
nullifier_non_inclusion::{prove_note_not_nullified, prove_note_not_nullified_at},
public_value_inclusion::{prove_public_value_inclusion, prove_public_value_inclusion_at}
};
// docs:end:imports
Expand Down Expand Up @@ -175,7 +172,7 @@ contract InclusionProofs {
fn test_nullifier_inclusion(
nullifier: Field,
use_block_number: bool,
block_number: u32 // The block at which we'll prove that the nullifier not exists in the tree
block_number: u32 // The block at which we'll prove that the nullifier exists in the nullifier tree
) {
if (use_block_number) {
// docs:start:prove_nullifier_inclusion
Expand Down
Loading