-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: decouple ypb #4749
chore: decouple ypb #4749
Changes from all commits
1e38125
31cf1a9
60a38d3
3af0393
42d1dea
97822b1
f4d59db
6ac2000
bd3a1bd
c52fec8
ad2659c
332e1a3
e40e51d
6ece897
2465a8d
0b0efad
5c56c48
e8b55f4
4e7f7cb
18bfdbb
40216be
7c308e3
df20fba
b6468a1
fefccb8
a694413
1871570
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,4 +5,5 @@ node_modules | |
.tsbuildinfo | ||
Dockerfile* | ||
.dockerignore | ||
docker-compose.yml | ||
docker-compose.yml | ||
**/artifacts |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -135,13 +135,8 @@ yarn-project-base: | |
- ^yarn-project/yarn.lock | ||
- ^yarn-project/.*/package.json$ | ||
dependencies: | ||
- l1-contracts | ||
- bb.js | ||
- noir | ||
- noir-packages | ||
- boxes-files | ||
- avm-transpiler | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as above. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Transpilation happens as part of noir-projects, not as part of yarn-project. |
||
- noir-projects | ||
|
||
yarn-project: | ||
buildDir: yarn-project | ||
|
@@ -151,6 +146,9 @@ yarn-project: | |
- ^yarn-project/cli/aztec-cli | ||
dependencies: | ||
- yarn-project-base | ||
- l1-contracts | ||
- boxes-files | ||
- noir-projects | ||
|
||
yarn-project-prod: | ||
buildDir: yarn-project | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the transpiler is removed and not added in yarn-project. Is this intentional? (I think it's currently needed to transpile just after compiling the contracts).