feat(noir): separate arguments of inputs #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalladino
approved these changes
May 4, 2023
| _call_context: pub CallContext, | ||
| amount: pub Field, | ||
| recipient: pub Point, | ||
| open fn mint( |
| fn constructor( | ||
| inputs: pub Inputs, | ||
| ) -> pub [Field; dep::aztec3::abi::PUBLIC_INPUTS_LENGTH] { | ||
| PrivateFunctionContext::new().finish(inputs) | ||
| } | ||
|
|
||
| /// ABI value type "secret" | ||
| /// ABI value params [{"name":"input","type":{"kind":"field"},"visibility":"public"}] | ||
| /// ABI value return [{"kind":"field"}] |
There was a problem hiding this comment.
Shouldn't we keep the return annotation at least? Can the client consume this value?
There was a problem hiding this comment.
Users currently cannot consume the return value for secret functions! The idea is to phase out the ABI manual comments for the introduction of the aztec noir compiler 😄
ludamad
added a commit
that referenced
this pull request
Jul 14, 2023
This was referenced Jul 25, 2023
codygunton
pushed a commit
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #455
Extracts the arguments from the inputs struct in noir contracts. For now they have to be manually pushed to the context.
Updates the postprocessor to omit the Inputs & CallContext, allowing to avoid writing ABI comments in the noir code.
Checklist: