Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pw/merkle tree readme #441

Merged
merged 3 commits into from
May 3, 2023
Merged

Pw/merkle tree readme #441

merged 3 commits into from
May 3, 2023

Conversation

PhilWindle
Copy link
Collaborator

Description

This PR adds a readme file for the Merkle Tree package

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@Maddiaa0 Maddiaa0 merged commit 75244dd into master May 3, 2023
@Maddiaa0 Maddiaa0 deleted the pw/merkle-tree-readme branch May 3, 2023 16:08
ludamad added a commit that referenced this pull request May 3, 2023
@Orloaft @LHerskind
@Maddiaa0 @PhilWindle @benesjan @ludamad
Update to makeImport function (#449)
5bfe7fd 
* partial import refactor commit

* partial import refactor commit

* partial import refactor commit

* add new export to foundation, partial import refactor

* partial import reformat

* add DebugLogger import

* adjust additional imports

* L1 contracts: readme + docker update (#422)

* chore: readme + docker update

* Apply suggestions from code review

Co-authored-by: Maddiaa <[email protected]>

---------

Co-authored-by: Maddiaa <[email protected]>

* feat: l1 to l2 messaging (#385)

* feat: initial decoder contact changes

* feat: add message snapshot to l2 block

* feat(world_state): add l2 merkle tree

* feat: add l1ToL2 roots tree to ts

* feat: historic l2 tree in l2 block

* feat: add l1->l2 messages types to root rollup

* feat: add to circuit powered block builder

* feat: add types to root rollup inputs

* feat: update root rollup circuit

* feat: add l1tol2 messages to the rollup calldata

* soldoc

* fix: pedersen segfault issue

temp commented out

fix: pedersen segfault issue

* clean: fix native root tests

* Add messages hash test

* feat: stub l1_to_l2_messages in block builder

* fix: update snaphshots in circuits.js

* fix: activate sim tree checking in rollup builder

* fix: update snapshot

* feat: add l2 block utilities

* fix: rebase cpp build issues

* feat: update l1 contract after rebase

* fix: update ts tests

* chore: update viem scripts

* chore: update ethjs helpers

* fix

* feat: update decoder.t.sol

* fix: re skip `l2-block-publisher.test.ts`

* chore: clang tidy fix

* fix: clang tidy

* run prettier

* fix: remove done todos

* fix: re introduce test initialiser lost in merge

* fix: move custom typing to its own file in the sequencer

* fix: add negative tests, cleanup

* chore: forge fmt

* fix: rename updateRootsTree -> updateHistoricRootsTree

* fix: update contract doc comment

* fix: update cpp test and naming nits

* fix: update trailing mock

---------

Co-authored-by: cheethas <[email protected]>

* Readme file for the world state package (#436)

* Readme file for the worl state package

* Review updates

* Review change

* Fixed linter errors + docs in archiver (#440)

* chore: enabled strict linter checks

* docs: fixed linting errors

* refactor: fixed inconsistent naming

* docs: updated readme

* Fixed linter errors + docs in types (#443)

* chore: enabled strict linter checks

* chore: fixed linter errors

* docs: udpated readme

* Pw/merkle tree readme (#441)

* Added readme file to Merkle Trees package

* Readme update

* update makeImport function ins ethereum.js

---------

Co-authored-by: Lasse Herskind <[email protected]>
Co-authored-by: Maddiaa <[email protected]>
Co-authored-by: cheethas <[email protected]>
Co-authored-by: PhilWindle <[email protected]>
Co-authored-by: Jan Beneš <[email protected]>
Co-authored-by: ludamad <[email protected]>
ludamad pushed a commit that referenced this pull request Jul 14, 2023
@zac-williamson @kevaundray
variable-length keccak (#441)
7549694 
* updated stdlib::keccak to be able to hash variable-length inputs (where input size not known at circuit-compile time, only a  maximum possible input size)

* compile error

* compile fils

* compiler fix

* more fix

* compiler fix

* compile fix

* Update cpp/src/barretenberg/stdlib/hash/keccak/keccak.test.cpp

Co-authored-by: kevaundray <[email protected]>

* Update cpp/src/barretenberg/stdlib/hash/keccak/keccak.test.cpp

Co-authored-by: kevaundray <[email protected]>

* Update cpp/src/barretenberg/stdlib/hash/keccak/keccak.test.cpp

Co-authored-by: kevaundray <[email protected]>

* Update cpp/src/barretenberg/stdlib/hash/keccak/keccak.test.cpp

Co-authored-by: kevaundray <[email protected]>

* Update cpp/src/barretenberg/stdlib/primitives/field/field.test.cpp

Co-authored-by: kevaundray <[email protected]>

* improved readability of stdlib test

* replaced magic numbers in keccak with constants + comments

---------

Co-authored-by: kevaundray <[email protected]>
codygunton pushed a commit that referenced this pull request Jan 23, 2024
@zac-williamson @kevaundray
variable-length keccak (#441)
d3cdd43 
* updated stdlib::keccak to be able to hash variable-length inputs (where input size not known at circuit-compile time, only a  maximum possible input size)

* compile error

* compile fils

* compiler fix

* more fix

* compiler fix

* compile fix

* Update cpp/src/barretenberg/stdlib/hash/keccak/keccak.test.cpp

Co-authored-by: kevaundray <[email protected]>

* Update cpp/src/barretenberg/stdlib/hash/keccak/keccak.test.cpp

Co-authored-by: kevaundray <[email protected]>

* Update cpp/src/barretenberg/stdlib/hash/keccak/keccak.test.cpp

Co-authored-by: kevaundray <[email protected]>

* Update cpp/src/barretenberg/stdlib/hash/keccak/keccak.test.cpp

Co-authored-by: kevaundray <[email protected]>

* Update cpp/src/barretenberg/stdlib/primitives/field/field.test.cpp

Co-authored-by: kevaundray <[email protected]>

* improved readability of stdlib test

* replaced magic numbers in keccak with constants + comments

---------

Co-authored-by: kevaundray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maddiaa0 Maddiaa0 Maddiaa0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilWindle @Maddiaa0