Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: removing redundant values from PrivateCircuitPublicInputs #4255

Closed
wants to merge 2 commits into from
Closed

feat: removing redundant values from PrivateCircuitPublicInputs #4255

wants to merge 2 commits into from

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Jan 29, 2024 •
edited
Loading

Fixes #4256

@benesjan Graphite App
Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Jan 29, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2024 •
edited
Loading

Changes to circuit sizes

Generated at commit: 29cc5dd36469b3bcbd50620153d69049f7808e2c, compared to commit: 19bd0661a763bfb1e70bca9fc45b4b90e8ae5e6f

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_inner 0 ➖ 0.00% -620 ✅ -0.12%
Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_inner 92,894 (0) 0.00% 522,458 (-620) -0.12%

@benesjan benesjan force-pushed the 01-19-refactor_nuking_block_header.nr branch 2 times, most recently from 93ddf9f to 9aa0a9f Compare January 29, 2024 16:11
@benesjan benesjan force-pushed the 01-19-refactor_nuking_block_header.nr branch from 9aa0a9f to 19bd066 Compare January 30, 2024 08:52
@benesjan benesjan force-pushed the 01-29-feat_removing_redundant_values_from_PrivateCircuitPublicInputs branch from d453292 to b578604 Compare January 30, 2024 08:53
@benesjan benesjan closed this Jan 30, 2024
@benesjan benesjan deleted the 01-29-feat_removing_redundant_values_from_PrivateCircuitPublicInputs branch January 30, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benesjan