Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish block body separately #4118

Merged
merged 14 commits into from
Jan 19, 2024

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented Jan 18, 2024

Fixes #3944

Note: Had to update Registry contract to handle AvailabilityOracle.

Copy link
Contributor Author

benesjan commented Jan 18, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@benesjan benesjan marked this pull request as draft January 18, 2024 09:13
@benesjan benesjan force-pushed the 01-18-feat_publish_block_body_separately branch from c4f026d to 976a909 Compare January 18, 2024 12:44
@AztecBot
Copy link
Collaborator

AztecBot commented Jan 18, 2024

Benchmark results

Metrics with a significant change:

  • l1_rollup_execution_gas (8): 314,123 (-66%)
  • l1_rollup_execution_gas (32): 984,460 (-75%)
  • l1_rollup_execution_gas (128): 3,667,877 (-85%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 7438db31 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,412 179,524 716,068
l1_rollup_calldata_gas 221,704 866,788 3,448,288
l1_rollup_execution_gas ⚠️ 314,123 (-66%) ⚠️ 984,460 (-75%) ⚠️ 3,667,877 (-85%)
l2_block_processing_time_in_ms 1,384 (-1%) 5,257 (-4%) 21,214 (-2%)
note_successful_decrypting_time_in_ms 311 920 (+1%) 3,325
note_trial_decrypting_time_in_ms 23.8 (+9%) 46.2 (+22%) 143 (+5%)
l2_block_building_time_in_ms 16,112 63,869 255,680
l2_block_rollup_simulation_time_in_ms 11,719 46,505 186,366
l2_block_public_tx_process_time_in_ms 4,358 17,274 68,916

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 16,170 30,782 (+2%)
note_history_successful_decrypting_time_in_ms 2,327 (+7%) 4,202 (-2%)
note_history_trial_decrypting_time_in_ms 106 (-13%) 172 (-2%)
node_database_size_in_bytes 3,583,904 3,653,288
pxe_database_size_in_bytes 29,923 59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 212 (-1%) 44,681 25,561
private-kernel-ordering 165 43,753 14,809
base-rollup 1,192 128,338 881
root-rollup 78.9 4,088 677
private-kernel-inner 291 71,208 25,561
public-kernel-private-input 205 31,863 25,561
public-kernel-non-first-iteration 203 31,905 25,561
merge-rollup 7.61 2,608 881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 2 leaves 8 leaves 16 leaves 32 leaves 128 leaves 64 leaves 512 leaves 1024 leaves 2048 leaves 8192 leaves
batch_insert_into_append_only_tree_16_depth_ms 12.0 (-3%) 20.6 (-4%) 13.6 (-1%) 19.5 (-4%) 26.2 (+4%) 67.3 (+3%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.9 17.5 23.0 31.6 47.0 143 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.618 (-1%) 0.654 (-3%) 0.549 0.549 0.488 0.443 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A N/A N/A N/A 91.1 (-1%) 52.0 (+2%) 249 491 (+3%) 913 (-1%) 3,564
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A N/A N/A N/A 159 96.0 543 1,055 2,079 8,223
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A N/A N/A N/A 0.512 (+3%) 0.502 (+1%) 0.437 0.451 (+3%) 0.431 (-1%) 0.427
batch_insert_into_indexed_tree_20_depth_ms N/A N/A N/A N/A N/A 125 (-2%) 61.6 (-2%) 372 (-1%) 784 (+3%) 1,436 5,881
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A N/A N/A N/A 197 104 691 1,363 2,707 10,771
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A N/A N/A N/A 0.523 (+2%) 0.502 (-1%) 0.478 0.500 (+4%) 0.474 0.483
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A 67.2 (-1%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A 94.1 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A 0.601 (+1%) N/A N/A N/A N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 15,455 32,219

Transaction processing duration by data writes.

Metric 0 new commitments 1 new commitments
tx_pxe_processing_time_ms 375 (-6%) 1,081
Metric 1 public data writes
tx_sequencer_processing_time_ms 534

@benesjan benesjan marked this pull request as ready for review January 18, 2024 15:16
@benesjan benesjan force-pushed the 01-18-feat_publish_block_body_separately branch from f39da30 to b9e80cc Compare January 18, 2024 15:34
Copy link
Contributor

@LHerskind LHerskind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally good, but have a few comments related to registries and synching.

l1-contracts/src/core/Rollup.sol Outdated Show resolved Hide resolved
* @notice Returns the availability oracle contract
* @return The availability oracle contract (of type IAvailabilityOracle)
*/
function getAvailabilityOracle() external view override(IRegistry) returns (IAvailabilityOracle) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned earlier. Think it is better to keep this immutable and non changing. In this model, it is possible to brick older instances.

Nevertheless I can follow adding in here for the purpose of getting addresses communicated to the nodes. Would it be useful for this case that we are making the snapshot to:
{instance, inbox, outbox, addresses_provider} where instance is the actor in the governance but addresses_provider can be an arbitrary contract that is just used for communicating instance specific addresses which might have a variable size. This way you could communicate 10 addresses if you need, or just a few.

@@ -107,7 +107,7 @@ async function getBlockFromCallData(
if (functionName !== 'process') {
throw new Error(`Unexpected method called ${functionName}`);
}
const [headerHex, archiveRootHex, bodyHex] = args! as [Hex, Hex, Hex, Hex];
const [headerHex, archiveRootHex, , bodyHex] = args! as [Hex, Hex, Hex, Hex, Hex];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you are working on #3938 would it not mess with your decoding here? It would not longer be practical to get the full block from just this kind of function call as the bodyHex would not be here.

This part seems to be very reliant on the content being published at the same time for getting any data.

In my mind you would need to fetch the body separately through the extra event you added. And then as l2 blocks are seen you can combine the two pieces together for the block.

As this is the synching part, it can be handled separately, a new pr for it might be nice to have the split fully dealt with? This seems a bit like cheating. But let us talk about it, as the new changes for messages would likely mess with it a bit, so an initial pr could focus on just needing to pass the messages and nothing else. That way we can address synching separately to the hashing updates.

Copy link
Contributor Author

@benesjan benesjan Jan 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my mind you would need to fetch the body separately through the extra event you added. And then as l2 blocks are seen you can combine the two pieces together for the block.

Yes, exactly. Would find the relevant event based on txsHash, from that get the transaction hash and from that the calldata.

And I just realized that for that I will need the index the hash in TxsPublished event. Will do that once I'll deal with this in that other PR.

yarn-project/end-to-end/src/fixtures/utils.ts Show resolved Hide resolved
// TODO: Remove this block number check, it's here because we don't currently have proper genesis state on the contract
if (block.number != 1 && !(await this.checkLastArchiveHash(lastArchive))) {
this.log(`Detected different last archive prior to publishing a block, aborting publish...`);
if (await this.txSender.checkIfTxsAreAvailable(block)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice 👍 Could be a neat test to check cost of sending an empty block of a size that have been sent before. The effects should be the same, so it is essentially just the header and proof you put in. Making it a viable option to have a small empty block in the backhand when sequencing 🤔

Likely also something that @Cooper-Kunz would find interesting.

account: this.account,
});
const hash = await this.availabilityOracleContract.write.publish(args, {
gas,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the real world should probably apply a small multiplier on the gas value here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that so? Are the estimations in precise?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If estimate is exact, and state that you touch is different than simulation you might revert. Don't know if the estimate is already applying one though.

@benesjan benesjan force-pushed the 01-18-feat_publish_block_body_separately branch from b9e80cc to 86428cf Compare January 19, 2024 07:59
@benesjan benesjan requested a review from LHerskind January 19, 2024 09:14
Copy link
Contributor

@LHerskind LHerskind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When combined with the separate pr for fixing synching think this is a nice step ahead 👍

@benesjan benesjan merged commit a04e1e3 into master Jan 19, 2024
84 checks passed
@benesjan benesjan deleted the 01-18-feat_publish_block_body_separately branch January 19, 2024 10:49
rahul-kothari pushed a commit that referenced this pull request Jan 23, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.20.0</summary>

##
[0.20.0](aztec-packages-v0.19.0...aztec-packages-v0.20.0)
(2024-01-22)


### ⚠ BREAKING CHANGES

* nullifier key
([#4166](#4166))
* Unify ABIs between nargo and yarn-project
([#3989](#3989))

### Features

* **avm:** Add internal jump and return, adjust control flow
([#4140](#4140))
([b77afb1](b77afb1))
* **avm:** Better field arithmetic
([#4142](#4142))
([7308e31](7308e31))
* **avm:** Encode TS AVM instructions as bytecode, especially for
testing
([#4115](#4115))
([de6e2ed](de6e2ed))
* **avm:** Improve interpreter errors and tests
([#4173](#4173))
([f0fb594](f0fb594))
* Benchmark commit function
([#4178](#4178))
([ea84085](ea84085))
* Goblin acir composer
([#4112](#4112))
([5e85b92](5e85b92))
* Nullifier key
([#4166](#4166))
([7c07665](7c07665))
* **public-vm:** Avm journal
([#3945](#3945))
([5658468](5658468))
* Publish block body separately
([#4118](#4118))
([a04e1e3](a04e1e3)),
closes
[#3944](#3944)
* Unify ABIs between nargo and yarn-project
([#3989](#3989))
([d083438](d083438))
* Update noir
([#4082](#4082))
([0e6037a](0e6037a))
* Updating L2 Block encoding and `Rollup.process` function
([#4015](#4015))
([2d8eb37](2d8eb37)),
closes
[#3936](#3936)
[#4010](#4010)
[#4011](#4011)


### Bug Fixes

* Bb.js version in yarn lockfile
([7b96760](7b96760))
* **build:** Publish bb.js from CCI
([#4151](#4151))
([09dbfcd](09dbfcd))
* Make CMake version warning fatal
([#4144](#4144))
([b1443fa](b1443fa))
* Misleading error message in `PublicState::read`
([#4149](#4149))
([fa4d919](fa4d919))
* Nargo destination path in bootstrap cache
([#4103](#4103))
([4901309](4901309))
* Reinstate Ultra arith rec verifier test
([#3886](#3886))
([995973b](995973b))
* Upload_benchmarks_to_s3.sh missing exit
([#4046](#4046))
([52a9327](52a9327))


### Miscellaneous

* Archiver store
([#3966](#3966))
([af2be87](af2be87))
* **avm:** List avm opcodes in a (enum =&gt; class) map in TS
([#4113](#4113))
([dee564a](dee564a))
* **bb:** More concise namespaces, plookup =&gt; bb::plookup
([#4146](#4146))
([14d39ed](14d39ed))
* **bb:** Namespace plonk::stdlib =&gt; stdlib
([#4117](#4117))
([cd2f67f](cd2f67f))
* **bb:** Namespace proof_system=&gt;bb
([#4116](#4116))
([7438db3](7438db3))
* **docs:** Aztec-up doesnt need `latest`, remove warnings around
sandbox/cli npm pkgs
([#4138](#4138))
([2bbf7a9](2bbf7a9))
* **docs:** Update js release notes for 0.18.0
([#4051](#4051))
([bdbe963](bdbe963))
* **docs:** Update lsp install instructions
([#4110](#4110))
([3138816](3138816)),
closes
[#4098](#4098)
* Dont mirror build-system mirror_repos.yml
([#4067](#4067))
([04f8e0d](04f8e0d))
* Fixes many broken urls
([#4109](#4109))
([41ae75c](41ae75c))
* Remove dependency cycles in `sequencer-client`
([#4017](#4017))
([fe4538b](fe4538b))
* Remove lodash times in favor of foundation fn
([#3877](#3877))
([a10eef0](a10eef0))
* Remove mutex dependency
([#4160](#4160))
([3b82be0](3b82be0))
* Remove unnecessary computation
([#4133](#4133))
([f35bdb8](f35bdb8))
* Remove unused noir-version json
([#4105](#4105))
([afca819](afca819))
* Remove unwanted submodules
([#4085](#4085))
([dda7c9c](dda7c9c))
* Replace relative paths to noir-protocol-circuits
([59feeb5](59feeb5))
* Replace relative paths to noir-protocol-circuits
([44d9136](44d9136))
* Replace relative paths to noir-protocol-circuits
([84b0bad](84b0bad))
* Simplify and fix DocsExample contract, e2e singleton + codegen to not
show internal methods
([#4169](#4169))
([38d262e](38d262e))
* Update noir
([#4168](#4168))
([d40ad06](d40ad06))


### Documentation

* Update migration notes
([#4175](#4175))
([dbc8174](dbc8174))
* **yellow-paper:** Update circuit sections for nullifier keys and
static calls
([#4155](#4155))
([ed71a57](ed71a57))
* **yellowpaper:** Refresh of avm instruction set
([#4081](#4081))
([52162ee](52162ee))
</details>

<details><summary>barretenberg.js: 0.20.0</summary>

##
[0.20.0](barretenberg.js-v0.19.0...barretenberg.js-v0.20.0)
(2024-01-22)


### Features

* Goblin acir composer
([#4112](#4112))
([5e85b92](5e85b92))
</details>

<details><summary>barretenberg: 0.20.0</summary>

##
[0.20.0](barretenberg-v0.19.0...barretenberg-v0.20.0)
(2024-01-22)


### Features

* Benchmark commit function
([#4178](#4178))
([ea84085](ea84085))
* Goblin acir composer
([#4112](#4112))
([5e85b92](5e85b92))


### Bug Fixes

* Make CMake version warning fatal
([#4144](#4144))
([b1443fa](b1443fa))
* Reinstate Ultra arith rec verifier test
([#3886](#3886))
([995973b](995973b))
* Upload_benchmarks_to_s3.sh missing exit
([#4046](#4046))
([52a9327](52a9327))


### Miscellaneous

* **bb:** More concise namespaces, plookup =&gt; bb::plookup
([#4146](#4146))
([14d39ed](14d39ed))
* **bb:** Namespace plonk::stdlib =&gt; stdlib
([#4117](#4117))
([cd2f67f](cd2f67f))
* **bb:** Namespace proof_system=&gt;bb
([#4116](#4116))
([7438db3](7438db3))
* Remove mutex dependency
([#4160](#4160))
([3b82be0](3b82be0))
* Remove unwanted submodules
([#4085](#4085))
([dda7c9c](dda7c9c))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Jan 24, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.20.0</summary>

##
[0.20.0](AztecProtocol/aztec-packages@aztec-packages-v0.19.0...aztec-packages-v0.20.0)
(2024-01-22)


### ⚠ BREAKING CHANGES

* nullifier key
([#4166](AztecProtocol/aztec-packages#4166))
* Unify ABIs between nargo and yarn-project
([#3989](AztecProtocol/aztec-packages#3989))

### Features

* **avm:** Add internal jump and return, adjust control flow
([#4140](AztecProtocol/aztec-packages#4140))
([b77afb1](AztecProtocol/aztec-packages@b77afb1))
* **avm:** Better field arithmetic
([#4142](AztecProtocol/aztec-packages#4142))
([7308e31](AztecProtocol/aztec-packages@7308e31))
* **avm:** Encode TS AVM instructions as bytecode, especially for
testing
([#4115](AztecProtocol/aztec-packages#4115))
([de6e2ed](AztecProtocol/aztec-packages@de6e2ed))
* **avm:** Improve interpreter errors and tests
([#4173](AztecProtocol/aztec-packages#4173))
([f0fb594](AztecProtocol/aztec-packages@f0fb594))
* Benchmark commit function
([#4178](AztecProtocol/aztec-packages#4178))
([ea84085](AztecProtocol/aztec-packages@ea84085))
* Goblin acir composer
([#4112](AztecProtocol/aztec-packages#4112))
([5e85b92](AztecProtocol/aztec-packages@5e85b92))
* Nullifier key
([#4166](AztecProtocol/aztec-packages#4166))
([7c07665](AztecProtocol/aztec-packages@7c07665))
* **public-vm:** Avm journal
([#3945](AztecProtocol/aztec-packages#3945))
([5658468](AztecProtocol/aztec-packages@5658468))
* Publish block body separately
([#4118](AztecProtocol/aztec-packages#4118))
([a04e1e3](AztecProtocol/aztec-packages@a04e1e3)),
closes
[#3944](AztecProtocol/aztec-packages#3944)
* Unify ABIs between nargo and yarn-project
([#3989](AztecProtocol/aztec-packages#3989))
([d083438](AztecProtocol/aztec-packages@d083438))
* Update noir
([#4082](AztecProtocol/aztec-packages#4082))
([0e6037a](AztecProtocol/aztec-packages@0e6037a))
* Updating L2 Block encoding and `Rollup.process` function
([#4015](AztecProtocol/aztec-packages#4015))
([2d8eb37](AztecProtocol/aztec-packages@2d8eb37)),
closes
[#3936](AztecProtocol/aztec-packages#3936)
[#4010](AztecProtocol/aztec-packages#4010)
[#4011](AztecProtocol/aztec-packages#4011)


### Bug Fixes

* Bb.js version in yarn lockfile
([7b96760](AztecProtocol/aztec-packages@7b96760))
* **build:** Publish bb.js from CCI
([#4151](AztecProtocol/aztec-packages#4151))
([09dbfcd](AztecProtocol/aztec-packages@09dbfcd))
* Make CMake version warning fatal
([#4144](AztecProtocol/aztec-packages#4144))
([b1443fa](AztecProtocol/aztec-packages@b1443fa))
* Misleading error message in `PublicState::read`
([#4149](AztecProtocol/aztec-packages#4149))
([fa4d919](AztecProtocol/aztec-packages@fa4d919))
* Nargo destination path in bootstrap cache
([#4103](AztecProtocol/aztec-packages#4103))
([4901309](AztecProtocol/aztec-packages@4901309))
* Reinstate Ultra arith rec verifier test
([#3886](AztecProtocol/aztec-packages#3886))
([995973b](AztecProtocol/aztec-packages@995973b))
* Upload_benchmarks_to_s3.sh missing exit
([#4046](AztecProtocol/aztec-packages#4046))
([52a9327](AztecProtocol/aztec-packages@52a9327))


### Miscellaneous

* Archiver store
([#3966](AztecProtocol/aztec-packages#3966))
([af2be87](AztecProtocol/aztec-packages@af2be87))
* **avm:** List avm opcodes in a (enum =&gt; class) map in TS
([#4113](AztecProtocol/aztec-packages#4113))
([dee564a](AztecProtocol/aztec-packages@dee564a))
* **bb:** More concise namespaces, plookup =&gt; bb::plookup
([#4146](AztecProtocol/aztec-packages#4146))
([14d39ed](AztecProtocol/aztec-packages@14d39ed))
* **bb:** Namespace plonk::stdlib =&gt; stdlib
([#4117](AztecProtocol/aztec-packages#4117))
([cd2f67f](AztecProtocol/aztec-packages@cd2f67f))
* **bb:** Namespace proof_system=&gt;bb
([#4116](AztecProtocol/aztec-packages#4116))
([7438db3](AztecProtocol/aztec-packages@7438db3))
* **docs:** Aztec-up doesnt need `latest`, remove warnings around
sandbox/cli npm pkgs
([#4138](AztecProtocol/aztec-packages#4138))
([2bbf7a9](AztecProtocol/aztec-packages@2bbf7a9))
* **docs:** Update js release notes for 0.18.0
([#4051](AztecProtocol/aztec-packages#4051))
([bdbe963](AztecProtocol/aztec-packages@bdbe963))
* **docs:** Update lsp install instructions
([#4110](AztecProtocol/aztec-packages#4110))
([3138816](AztecProtocol/aztec-packages@3138816)),
closes
[#4098](AztecProtocol/aztec-packages#4098)
* Dont mirror build-system mirror_repos.yml
([#4067](AztecProtocol/aztec-packages#4067))
([04f8e0d](AztecProtocol/aztec-packages@04f8e0d))
* Fixes many broken urls
([#4109](AztecProtocol/aztec-packages#4109))
([41ae75c](AztecProtocol/aztec-packages@41ae75c))
* Remove dependency cycles in `sequencer-client`
([#4017](AztecProtocol/aztec-packages#4017))
([fe4538b](AztecProtocol/aztec-packages@fe4538b))
* Remove lodash times in favor of foundation fn
([#3877](AztecProtocol/aztec-packages#3877))
([a10eef0](AztecProtocol/aztec-packages@a10eef0))
* Remove mutex dependency
([#4160](AztecProtocol/aztec-packages#4160))
([3b82be0](AztecProtocol/aztec-packages@3b82be0))
* Remove unnecessary computation
([#4133](AztecProtocol/aztec-packages#4133))
([f35bdb8](AztecProtocol/aztec-packages@f35bdb8))
* Remove unused noir-version json
([#4105](AztecProtocol/aztec-packages#4105))
([afca819](AztecProtocol/aztec-packages@afca819))
* Remove unwanted submodules
([#4085](AztecProtocol/aztec-packages#4085))
([dda7c9c](AztecProtocol/aztec-packages@dda7c9c))
* Replace relative paths to noir-protocol-circuits
([59feeb5](AztecProtocol/aztec-packages@59feeb5))
* Replace relative paths to noir-protocol-circuits
([44d9136](AztecProtocol/aztec-packages@44d9136))
* Replace relative paths to noir-protocol-circuits
([84b0bad](AztecProtocol/aztec-packages@84b0bad))
* Simplify and fix DocsExample contract, e2e singleton + codegen to not
show internal methods
([#4169](AztecProtocol/aztec-packages#4169))
([38d262e](AztecProtocol/aztec-packages@38d262e))
* Update noir
([#4168](AztecProtocol/aztec-packages#4168))
([d40ad06](AztecProtocol/aztec-packages@d40ad06))


### Documentation

* Update migration notes
([#4175](AztecProtocol/aztec-packages#4175))
([dbc8174](AztecProtocol/aztec-packages@dbc8174))
* **yellow-paper:** Update circuit sections for nullifier keys and
static calls
([#4155](AztecProtocol/aztec-packages#4155))
([ed71a57](AztecProtocol/aztec-packages@ed71a57))
* **yellowpaper:** Refresh of avm instruction set
([#4081](AztecProtocol/aztec-packages#4081))
([52162ee](AztecProtocol/aztec-packages@52162ee))
</details>

<details><summary>barretenberg.js: 0.20.0</summary>

##
[0.20.0](AztecProtocol/aztec-packages@barretenberg.js-v0.19.0...barretenberg.js-v0.20.0)
(2024-01-22)


### Features

* Goblin acir composer
([#4112](AztecProtocol/aztec-packages#4112))
([5e85b92](AztecProtocol/aztec-packages@5e85b92))
</details>

<details><summary>barretenberg: 0.20.0</summary>

##
[0.20.0](AztecProtocol/aztec-packages@barretenberg-v0.19.0...barretenberg-v0.20.0)
(2024-01-22)


### Features

* Benchmark commit function
([#4178](AztecProtocol/aztec-packages#4178))
([ea84085](AztecProtocol/aztec-packages@ea84085))
* Goblin acir composer
([#4112](AztecProtocol/aztec-packages#4112))
([5e85b92](AztecProtocol/aztec-packages@5e85b92))


### Bug Fixes

* Make CMake version warning fatal
([#4144](AztecProtocol/aztec-packages#4144))
([b1443fa](AztecProtocol/aztec-packages@b1443fa))
* Reinstate Ultra arith rec verifier test
([#3886](AztecProtocol/aztec-packages#3886))
([995973b](AztecProtocol/aztec-packages@995973b))
* Upload_benchmarks_to_s3.sh missing exit
([#4046](AztecProtocol/aztec-packages#4046))
([52a9327](AztecProtocol/aztec-packages@52a9327))


### Miscellaneous

* **bb:** More concise namespaces, plookup =&gt; bb::plookup
([#4146](AztecProtocol/aztec-packages#4146))
([14d39ed](AztecProtocol/aztec-packages@14d39ed))
* **bb:** Namespace plonk::stdlib =&gt; stdlib
([#4117](AztecProtocol/aztec-packages#4117))
([cd2f67f](AztecProtocol/aztec-packages@cd2f67f))
* **bb:** Namespace proof_system=&gt;bb
([#4116](AztecProtocol/aztec-packages#4116))
([7438db3](AztecProtocol/aztec-packages@7438db3))
* Remove mutex dependency
([#4160](AztecProtocol/aztec-packages#4160))
([3b82be0](AztecProtocol/aztec-packages@3b82be0))
* Remove unwanted submodules
([#4085](AztecProtocol/aztec-packages#4085))
([dda7c9c](AztecProtocol/aztec-packages@dda7c9c))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
michaelelliot pushed a commit to Swoir/noir_rs that referenced this pull request Feb 28, 2024
michaelelliot pushed a commit to Swoir/noir_rs that referenced this pull request Feb 28, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.20.0</summary>

##
[0.20.0](AztecProtocol/aztec-packages@aztec-packages-v0.19.0...aztec-packages-v0.20.0)
(2024-01-22)


### ⚠ BREAKING CHANGES

* nullifier key
([AztecProtocol#4166](AztecProtocol#4166))
* Unify ABIs between nargo and yarn-project
([AztecProtocol#3989](AztecProtocol#3989))

### Features

* **avm:** Add internal jump and return, adjust control flow
([AztecProtocol#4140](AztecProtocol#4140))
([b77afb1](AztecProtocol@b77afb1))
* **avm:** Better field arithmetic
([AztecProtocol#4142](AztecProtocol#4142))
([7308e31](AztecProtocol@7308e31))
* **avm:** Encode TS AVM instructions as bytecode, especially for
testing
([AztecProtocol#4115](AztecProtocol#4115))
([de6e2ed](AztecProtocol@de6e2ed))
* **avm:** Improve interpreter errors and tests
([AztecProtocol#4173](AztecProtocol#4173))
([f0fb594](AztecProtocol@f0fb594))
* Benchmark commit function
([AztecProtocol#4178](AztecProtocol#4178))
([ea84085](AztecProtocol@ea84085))
* Goblin acir composer
([AztecProtocol#4112](AztecProtocol#4112))
([5e85b92](AztecProtocol@5e85b92))
* Nullifier key
([AztecProtocol#4166](AztecProtocol#4166))
([7c07665](AztecProtocol@7c07665))
* **public-vm:** Avm journal
([AztecProtocol#3945](AztecProtocol#3945))
([5658468](AztecProtocol@5658468))
* Publish block body separately
([AztecProtocol#4118](AztecProtocol#4118))
([a04e1e3](AztecProtocol@a04e1e3)),
closes
[AztecProtocol#3944](AztecProtocol#3944)
* Unify ABIs between nargo and yarn-project
([AztecProtocol#3989](AztecProtocol#3989))
([d083438](AztecProtocol@d083438))
* Update noir
([AztecProtocol#4082](AztecProtocol#4082))
([0e6037a](AztecProtocol@0e6037a))
* Updating L2 Block encoding and `Rollup.process` function
([AztecProtocol#4015](AztecProtocol#4015))
([2d8eb37](AztecProtocol@2d8eb37)),
closes
[AztecProtocol#3936](AztecProtocol#3936)
[AztecProtocol#4010](AztecProtocol#4010)
[AztecProtocol#4011](AztecProtocol#4011)


### Bug Fixes

* Bb.js version in yarn lockfile
([7b96760](AztecProtocol@7b96760))
* **build:** Publish bb.js from CCI
([AztecProtocol#4151](AztecProtocol#4151))
([09dbfcd](AztecProtocol@09dbfcd))
* Make CMake version warning fatal
([AztecProtocol#4144](AztecProtocol#4144))
([b1443fa](AztecProtocol@b1443fa))
* Misleading error message in `PublicState::read`
([AztecProtocol#4149](AztecProtocol#4149))
([fa4d919](AztecProtocol@fa4d919))
* Nargo destination path in bootstrap cache
([AztecProtocol#4103](AztecProtocol#4103))
([4901309](AztecProtocol@4901309))
* Reinstate Ultra arith rec verifier test
([AztecProtocol#3886](AztecProtocol#3886))
([995973b](AztecProtocol@995973b))
* Upload_benchmarks_to_s3.sh missing exit
([AztecProtocol#4046](AztecProtocol#4046))
([52a9327](AztecProtocol@52a9327))


### Miscellaneous

* Archiver store
([AztecProtocol#3966](AztecProtocol#3966))
([af2be87](AztecProtocol@af2be87))
* **avm:** List avm opcodes in a (enum =&gt; class) map in TS
([AztecProtocol#4113](AztecProtocol#4113))
([dee564a](AztecProtocol@dee564a))
* **bb:** More concise namespaces, plookup =&gt; bb::plookup
([AztecProtocol#4146](AztecProtocol#4146))
([14d39ed](AztecProtocol@14d39ed))
* **bb:** Namespace plonk::stdlib =&gt; stdlib
([AztecProtocol#4117](AztecProtocol#4117))
([cd2f67f](AztecProtocol@cd2f67f))
* **bb:** Namespace proof_system=&gt;bb
([AztecProtocol#4116](AztecProtocol#4116))
([7438db3](AztecProtocol@7438db3))
* **docs:** Aztec-up doesnt need `latest`, remove warnings around
sandbox/cli npm pkgs
([AztecProtocol#4138](AztecProtocol#4138))
([2bbf7a9](AztecProtocol@2bbf7a9))
* **docs:** Update js release notes for 0.18.0
([AztecProtocol#4051](AztecProtocol#4051))
([bdbe963](AztecProtocol@bdbe963))
* **docs:** Update lsp install instructions
([AztecProtocol#4110](AztecProtocol#4110))
([3138816](AztecProtocol@3138816)),
closes
[AztecProtocol#4098](AztecProtocol#4098)
* Dont mirror build-system mirror_repos.yml
([AztecProtocol#4067](AztecProtocol#4067))
([04f8e0d](AztecProtocol@04f8e0d))
* Fixes many broken urls
([AztecProtocol#4109](AztecProtocol#4109))
([41ae75c](AztecProtocol@41ae75c))
* Remove dependency cycles in `sequencer-client`
([AztecProtocol#4017](AztecProtocol#4017))
([fe4538b](AztecProtocol@fe4538b))
* Remove lodash times in favor of foundation fn
([AztecProtocol#3877](AztecProtocol#3877))
([a10eef0](AztecProtocol@a10eef0))
* Remove mutex dependency
([AztecProtocol#4160](AztecProtocol#4160))
([3b82be0](AztecProtocol@3b82be0))
* Remove unnecessary computation
([AztecProtocol#4133](AztecProtocol#4133))
([f35bdb8](AztecProtocol@f35bdb8))
* Remove unused noir-version json
([AztecProtocol#4105](AztecProtocol#4105))
([afca819](AztecProtocol@afca819))
* Remove unwanted submodules
([AztecProtocol#4085](AztecProtocol#4085))
([dda7c9c](AztecProtocol@dda7c9c))
* Replace relative paths to noir-protocol-circuits
([59feeb5](AztecProtocol@59feeb5))
* Replace relative paths to noir-protocol-circuits
([44d9136](AztecProtocol@44d9136))
* Replace relative paths to noir-protocol-circuits
([84b0bad](AztecProtocol@84b0bad))
* Simplify and fix DocsExample contract, e2e singleton + codegen to not
show internal methods
([AztecProtocol#4169](AztecProtocol#4169))
([38d262e](AztecProtocol@38d262e))
* Update noir
([AztecProtocol#4168](AztecProtocol#4168))
([d40ad06](AztecProtocol@d40ad06))


### Documentation

* Update migration notes
([AztecProtocol#4175](AztecProtocol#4175))
([dbc8174](AztecProtocol@dbc8174))
* **yellow-paper:** Update circuit sections for nullifier keys and
static calls
([AztecProtocol#4155](AztecProtocol#4155))
([ed71a57](AztecProtocol@ed71a57))
* **yellowpaper:** Refresh of avm instruction set
([AztecProtocol#4081](AztecProtocol#4081))
([52162ee](AztecProtocol@52162ee))
</details>

<details><summary>barretenberg.js: 0.20.0</summary>

##
[0.20.0](AztecProtocol/aztec-packages@barretenberg.js-v0.19.0...barretenberg.js-v0.20.0)
(2024-01-22)


### Features

* Goblin acir composer
([AztecProtocol#4112](AztecProtocol#4112))
([5e85b92](AztecProtocol@5e85b92))
</details>

<details><summary>barretenberg: 0.20.0</summary>

##
[0.20.0](AztecProtocol/aztec-packages@barretenberg-v0.19.0...barretenberg-v0.20.0)
(2024-01-22)


### Features

* Benchmark commit function
([AztecProtocol#4178](AztecProtocol#4178))
([ea84085](AztecProtocol@ea84085))
* Goblin acir composer
([AztecProtocol#4112](AztecProtocol#4112))
([5e85b92](AztecProtocol@5e85b92))


### Bug Fixes

* Make CMake version warning fatal
([AztecProtocol#4144](AztecProtocol#4144))
([b1443fa](AztecProtocol@b1443fa))
* Reinstate Ultra arith rec verifier test
([AztecProtocol#3886](AztecProtocol#3886))
([995973b](AztecProtocol@995973b))
* Upload_benchmarks_to_s3.sh missing exit
([AztecProtocol#4046](AztecProtocol#4046))
([52a9327](AztecProtocol@52a9327))


### Miscellaneous

* **bb:** More concise namespaces, plookup =&gt; bb::plookup
([AztecProtocol#4146](AztecProtocol#4146))
([14d39ed](AztecProtocol@14d39ed))
* **bb:** Namespace plonk::stdlib =&gt; stdlib
([AztecProtocol#4117](AztecProtocol#4117))
([cd2f67f](AztecProtocol@cd2f67f))
* **bb:** Namespace proof_system=&gt;bb
([AztecProtocol#4116](AztecProtocol#4116))
([7438db3](AztecProtocol@7438db3))
* Remove mutex dependency
([AztecProtocol#4160](AztecProtocol#4160))
([3b82be0](AztecProtocol@3b82be0))
* Remove unwanted submodules
([AztecProtocol#4085](AztecProtocol#4085))
([dda7c9c](AztecProtocol@dda7c9c))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Publish data separately before the transaction with the header (node changes as well)
4 participants