Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix various warnings in noir-protocol-circuits #4048

Merged
merged 1 commit into from
Jan 16, 2024
Merged

fix: fix various warnings in noir-protocol-circuits #4048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions barretenberg/cpp/_deps/benchmark-src
Open in desktop
Submodule benchmark-src added at d572f4
1 change: 1 addition & 0 deletions barretenberg/cpp/_deps/gtest-src
Open in desktop
Submodule gtest-src added at 703bd9
4 changes: 2 additions & 2 deletions yarn-project/noir-protocol-circuits/src/crates/rollup-lib/src/base/base_rollup_inputs.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ impl BaseRollupInputs {
)
}

fn create_nullifier_subtree<N>(self, leaves: [NullifierLeafPreimage; N]) -> Field {
fn create_nullifier_subtree<N>(leaves: [NullifierLeafPreimage; N]) -> Field {
TomAFrench marked this conversation as resolved.
Show resolved Hide resolved
calculate_subtree(leaves.map(|leaf:NullifierLeafPreimage| leaf.hash()))
}

Expand Down Expand Up @@ -359,7 +359,7 @@ impl BaseRollupInputs {
}
}

fn verify_kernel_proof(proof: Proof) -> bool {
fn verify_kernel_proof(_proof: Proof) -> bool {
// TODO: Just return true as we are mocking out the proof verification
// and aggregation.
// TODO(Kev): It may make sense to move all of these methods into a
Expand Down
2 changes: 1 addition & 1 deletion yarn-project/noir-protocol-circuits/src/crates/rollup-lib/src/components.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ use dep::types::abis::append_only_tree_snapshot::AppendOnlyTreeSnapshot;
*/
pub fn aggregate_proofs(
left: BaseOrMergeRollupPublicInputs,
right: BaseOrMergeRollupPublicInputs
_right: BaseOrMergeRollupPublicInputs
) -> AggregationObject {
// TODO: Similar to cpp code this does not do anything.
left.aggregation_object
Expand Down
2 changes: 1 addition & 1 deletion yarn-project/noir-protocol-circuits/src/crates/rollup-lib/src/merkle_tree.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ struct MerkleTree<N> {
}

impl<N> MerkleTree<N> {
fn new(leaves: [Field; N]) -> Self {
pub fn new(leaves: [Field; N]) -> Self {
let mut nodes = [0; N];

// We need one less node than leaves, but we cannot have computed array lengths
Expand Down
Loading